Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1t5B4i-004Sw4-OE for pgsql-hackers@arkaria.postgresql.org; Sun, 27 Oct 2024 21:45:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1t5B4h-001S5n-2V for pgsql-hackers@arkaria.postgresql.org; Sun, 27 Oct 2024 21:45:27 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1t5B4g-001S5e-NJ for pgsql-hackers@lists.postgresql.org; Sun, 27 Oct 2024 21:45:27 +0000 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1t5B4e-003AVV-Hb for pgsql-hackers@postgresql.org; Sun, 27 Oct 2024 21:45:25 +0000 Received: by mail-pj1-x102f.google.com with SMTP id 98e67ed59e1d1-2e3fca72a41so2907043a91.1 for ; Sun, 27 Oct 2024 14:45:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leadboat.com; s=google; t=1730065523; x=1730670323; darn=postgresql.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=jHsr5LJmsdH8HuZWhSv/JzMC8I0+jagmItGgFYvcxMo=; b=KGxLSh+BorNcJsRlWPXr2y9tNMEb68xI4KY6QoXRsu6NqxpqqxjKdzQqjDhf/9a/6q meloBSnz+uvFD0OerPpBi86HmHztBUhpqypuYErNX/NJgJJMKWZuNkMc0FKwNGhR6p9S ER21pia9z6u3MMsc2o74i1NwoVFk+Y/5nN0oo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730065523; x=1730670323; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jHsr5LJmsdH8HuZWhSv/JzMC8I0+jagmItGgFYvcxMo=; b=qZFen+kh03MqcHx22GT6m+LcxG0aCb/QsOr9DPf2QZw+Qvli56ins32klKF9BZIVWw 5GYNMlj3p1hY4XZ6w8Ajm7jC9sxPdEPRD4Ws4J9VzK+Mpa/nIF/czIoReocLzarOx1FG Ea3vj5UWN/Hj7ZgWuzbxoTCWrF6/i4wUONnedcnHLIOixugmYrvBuKwIHlD/8HwWu843 J/m7HJKgf02dfAK586jb/Z5gHjbBj66AitmQhDiUSsbfAcPvmQQ7Yx4XlrNm1eNQTNl/ awG20dQPpTiyY6+19mSzRC2mSGit4st4e3DAdtB0wyeBFDQE5Zh6+wd+U5f+a2bmSl/W DUow== X-Forwarded-Encrypted: i=1; AJvYcCVdg0zyjDgZXO3YUn+ZFFtx1Rq2qb07WWGCaLAdOS5U3q0q1qkvAsdtpwO6b9AbBPVE2WIniCr0w9wc7VJQ@postgresql.org X-Gm-Message-State: AOJu0YxxJlBcmEVKUJpRdlq/LRS9w8LjGoJaXLIhSME0vo8X06QEiyeY M3FTTXLUXLEexBXDC4+fZdfMCc9Lav3Q4bHjILAf3jBN1Qc3ijPkLBFLuD0f4Q== X-Google-Smtp-Source: AGHT+IH1HhyVlovq33nhBX4lD6RR71Who5oB7OXsykP6AXtnev2nOGdrHoo4gxNcYlNHsSqSoCugnw== X-Received: by 2002:a17:90a:cf97:b0:2e2:cd2f:b919 with SMTP id 98e67ed59e1d1-2e8f10a6e95mr7677353a91.28.1730065523512; Sun, 27 Oct 2024 14:45:23 -0700 (PDT) Received: from google.com (108-233-125-46.lightspeed.sntcca.sbcglobal.net. [108.233.125.46]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e77e5864e6sm7610102a91.47.2024.10.27.14.45.22 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 27 Oct 2024 14:45:23 -0700 (PDT) Date: Sun, 27 Oct 2024 14:45:11 -0700 From: Noah Misch To: Heikki Linnakangas Cc: Robert Haas , pgsql-hackers@postgresql.org, Tom Lane , Smolkin Grigory , Michael Paquier , Alexander Lakhin Subject: Re: race condition in pg_class Message-ID: <20241027214511.3c.nmisch@google.com> References: <20240614003549.c2.nmisch@google.com> <20240621212842.98.nmisch@google.com> <20240628051353.a0.nmisch@google.com> <20240704220816.51.nmisch@google.com> <20240714174800.de.nmisch@google.com> <20240817040748.f8.nmisch@google.com> <63c27c17-0d8f-4ede-a624-3ee41d28b539@iki.fi> <20240822073200.4f.nmisch@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240822073200.4f.nmisch@google.com> User-Agent: Mutt/2.2.12 (2023-09-09) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, Aug 22, 2024 at 12:32:00AM -0700, Noah Misch wrote: > This move also loses the optimization of unpinning before XactLockTableWait(). > heap_update() doesn't optimize that way, so that's fine. In this other thread, I'm proposing to go back to unpinning: https://postgr.es/m/20241027214035.8a.nmisch@google.com