Date: Wed, 30 Oct 2024 18:39:24 -0700
From: Noah Misch <noah@leadboat.com>
To: Nitin Motiani <nitinmotiani@google.com>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org
Subject: Re: Inval reliability, especially for inplace updates
Message-ID: <20241031013924.cd.nmisch@google.com>
References: <20240618015730.jijhox2a3w3t26en@awork3.anarazel.de>
 <20240618152349.7f.nmisch@google.com>
 <20240831010711.67.nmisch@google.com>
 <20240930193350.04.nmisch@google.com>
 <CAH5HC9508Xvz4BVca8OCoDOv7pgHqAf85EqZkWMZ_Q2hAkebzg@mail.gmail.com>
 <20241013004511.9c.nmisch@google.com>
 <CAH5HC94r2ZKy_MhNaPUjn7NHkOFgbyBAgV2jaYSRt35BNWuOAA@mail.gmail.com>
 <CAH5HC95rn4gON8zNrFXFY-Cn4z0NZuDU_1TDwKnafX_25_C0UA@mail.gmail.com>
 <20241024025357.a8.nmisch@google.com>
 <CAH5HC97fbvr63wJO23k6N0YmQh8BK3QE8ch3cQC=dWJJBxaCjw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAH5HC97fbvr63wJO23k6N0YmQh8BK3QE8ch3cQC=dWJJBxaCjw@mail.gmail.com>
User-Agent: Mutt/2.2.12 (2023-09-09)
Archived-At: 
 <https://www.postgresql.org/message-id/20241031013924.cd.nmisch%40google.com>
Precedence: bulk

On Mon, Oct 28, 2024 at 02:27:03PM +0530, Nitin Motiani wrote:
> On Thu, Oct 24, 2024 at 8:24 AM Noah Misch <noah@leadboat.com> wrote:
> > With the releases wrapping in 2.5 weeks, I'm ambivalent about pushing this
> > before the release or after.  Pushing before means fewer occurrences of
> > corruption, but pushing after gives more bake time to discover these changes
> > were defective.  It's hard to predict which helps users more, on a
> > risk-adjusted basis.  I'm leaning toward pushing this week.  Opinions?
> 
> I lean towards pushing after the release. This is based on my
> assumption that since this bug has been around for a while, it is
> (probably) not hit often. And a few weeks delay is better than
> introducing a new defect.

I had pushed this during the indicated week, before your mail.  Reverting it
is an option.  Let's see if more opinions arrive.