Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tAwIO-000z2i-Mh for pgsql-hackers@arkaria.postgresql.org; Tue, 12 Nov 2024 19:11:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tAwIK-008mj9-B9 for pgsql-hackers@arkaria.postgresql.org; Tue, 12 Nov 2024 19:11:20 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tAwII-008miv-NH for pgsql-hackers@lists.postgresql.org; Tue, 12 Nov 2024 19:11:20 +0000 Received: from fout-b1-smtp.messagingengine.com ([202.12.124.144]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tAwIC-001X5O-G9 for pgsql-hackers@postgresql.org; Tue, 12 Nov 2024 19:11:18 +0000 Received: from phl-compute-04.internal (phl-compute-04.phl.internal [10.202.2.44]) by mailfout.stl.internal (Postfix) with ESMTP id E58EF11400AF; Tue, 12 Nov 2024 14:11:10 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-04.internal (MEProxy); Tue, 12 Nov 2024 14:11:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1731438670; x=1731525070; bh=J KdABruZ+Q+ChgaMdh5WLu+gPGCJ30MjW7Jr6v3Mhtg=; b=D6yzNIgDCQgFfC6Ku 7zQVbv0SIMjgJEb4ZZ4/d/6pwX630DYJ7KD8fe34m5xth6nnnYexDecwi0PaKWAk DTGKVJHQpgoEFsGeGa4WbYAkK7B0p7R66grwviRRYYkiCTc4bHnOS+J7oUYJINM0 Fttqe8/TP6EOqEBCv4+A99gJYcHQHoRv7CV+9wVvVI6+PuG8PLmbGTQIJYVU1LJQ Wkuc4zCrHR7BroASnA1OWgtmw5BvANP/OR0EDH5qH6/Spm+gDbcHnWO80+Y8pM4i BZ2p2x5hoePwKE81jPojZ2UP1xAeXWXcGwckzW76hn9l3b92UFcWMTxcwwMjq206 +TTvA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrudeggdduudekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepfffhvfevuffkgggtugfgjgesthekredttddtjeen ucfhrhhomheptehlvhgrrhhoucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsegrlhhvhh drnhhoqdhiphdrohhrgheqnecuggftrfgrthhtvghrnhepvdektdffudfftdffffehfffh jeejhffgieeuueekjeekfffgudffhfduffffueevnecuffhomhgrihhnpegvnhhtvghrph hrihhsvggusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgr ihhlfhhrohhmpegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgpdhnsggprh gtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehrrghnihgvrhdr vhhfsehgmhgrihhlrdgtohhmpdhrtghpthhtohepphhgshhqlhdqhhgrtghkvghrshesph hoshhtghhrvghsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 12 Nov 2024 14:11:10 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alvh.no-ip.org; s=schmee; t=1731438667; bh=jSYNkVcmvUn+bQiz4v+uGqAEV61F6Ptf2t5PEo7blOE=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=DJimRkfK+ftz9DLZPIzXNRYu4DgIE7AN9UQB9ff6idSXbQIT19SfQ2VHRR/7dEY0O UvlSpjL6KPYev3DgcYnyMMU6s3YdLIu3YcO6yOLdITJBxMMEekuDdJG0Afomvsk6gb faB0RPm+fKO17+6zC61UsHaWUjRz6QZqZBD+ql98eWlOSePNvZLbQaUy8iz0M1OOGx hOORbSQlLJsZj++g1Rxecnjf65kKSZRh2zUY8NfUsXf3C/BUI7OzGbqXnbmoRR1H7W CWnCqk0VBxOPMBmiGXdEwhgdblTcFClmGu61nSNhpsQkbO1YZhUp8srSN5fK8NKX+6 yMrlYY/pqT+EQ== Received: by schmee.alvh.no-ip.org (Postfix, from userid 1000) id 576DA95; Tue, 12 Nov 2024 20:11:07 +0100 (CET) Date: Tue, 12 Nov 2024 20:11:07 +0100 From: Alvaro Herrera To: Ranier Vilela Cc: Pg Hackers Subject: Re: Fix array access (src/bin/pg_dump/pg_dump.c) Message-ID: <202411121911.3vwdrzfgjt4o@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2024-Nov-12, Ranier Vilela wrote: > Per Coverity. > > The function *determineNotNullFlags* has a little oversight. > The struct field *notnull_islocal* is an array. > > I think this is a simple typo. > Fix using array notation access. Yeah, thanks, I had been made aware of this bug. Before fixing I'd like to construct a test case that tickles that code, because it's currently uncovered *shudder* -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/ "Find a bug in a program, and fix it, and the program will work today. Show the program how to find and fix a bug, and the program will work forever" (Oliver Silfridge)