Date: Mon, 25 Nov 2024 08:31:55 +0900 (JST)
Message-Id: <20241125.083155.1820744655877715597.ishii@postgresql.org>
To: masao.fujii@oss.nttdata.com
Cc: btogiwarayuushi@oss.nttdata.com, pgsql-hackers@postgresql.org
Subject: Re: Fix for Extra Parenthesis in pgbench progress message
From: Tatsuo Ishii <ishii@postgresql.org>
In-Reply-To: <95f1100e-e59b-41b7-a406-f865c2e69db7@oss.nttdata.com>
References: <85fe426d-248a-47f7-8784-22af811ee572@oss.nttdata.com>
	<20241108.114713.484828673471024549.ishii@postgresql.org>
	<95f1100e-e59b-41b7-a406-f865c2e69db7@oss.nttdata.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/20241125.083155.1820744655877715597.ishii%40postgresql.org>
Precedence: bulk

Hi Fujii-san,

> On 2024/11/08 11:47, Tatsuo Ishii wrote:
>> I think you need to adjust
>> 		fprintf(stderr, "%*c\r", chars - 1, ' '); /* Clear the current line */
>> to:
>> 		fprintf(stderr, "%*c\r", chars, ' ');	/* Clear the current line */
>> since now chars does not consider the EOL char. By clearing chars - 1,
>> the closing parenthesis will be left on the screen.
> 
> You're right! I've updated the patch and attached v4.
> 
> About the back-patch: initially, there were concerns it might be too
> invasive,
> as you told upthread. However, after our discussion, I think the
> latest version
> is straightforward enough, and I'm okay with back-patching
> it. Thoughts?
> 
> Since the minor release freeze is already in effect, if we commit this
> patch,
> we'll need to wait until the next minor releases are out next week
> before
> the commit and back-patch.

Now that two minor releases are out, are you going to commit and
back-patch this?
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp