Date: Tue, 26 Nov 2024 18:25:13 +0900 (JST)
Message-Id: <20241126.182513.1752581942460106099.ishii@postgresql.org>
To: nagata@sraoss.co.jp
Cc: bruce@momjian.us, peter@eisentraut.org, tgl@sss.pgh.pa.us,
 daniel@yesql.se, pgsql-hackers@postgresql.org
Subject: Re: Doc: typo in config.sgml
From: Tatsuo Ishii <ishii@postgresql.org>
In-Reply-To: <20241119193121.7ba727c489b5f0b6d20f9c25@sraoss.co.jp>
References: <20241119112907.1cdfe086df16e7ac173f9571@sraoss.co.jp>
	<ZzwA_DayripquW7e@momjian.us>
	<20241119193121.7ba727c489b5f0b6d20f9c25@sraoss.co.jp>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/20241126.182513.1752581942460106099.ishii%40postgresql.org>
Precedence: bulk

I have looked into the patches.

> Subject: [PATCH v3 1/3] Disallow characters that cannot be displayed in PDF
> 
> ---
>  doc/src/sgml/Makefile | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/src/sgml/Makefile b/doc/src/sgml/Makefile
> index a04c532b53..18bf87d031 100644
> --- a/doc/src/sgml/Makefile
> +++ b/doc/src/sgml/Makefile
> @@ -156,7 +156,9 @@ XSLTPROC_FO_FLAGS += --stringparam img.src.path '$(srcdir)/'
>  	$(XSLTPROC) $(XMLINCLUDE) $(XSLTPROCFLAGS) $(XSLTPROC_FO_FLAGS) --stringparam paper.type USletter -o $@ $^
>  
>  %.pdf: %.fo $(ALL_IMAGES)
> -	$(FOP) -fo $< -pdf $@
> +	CLANG=C $(FOP) -fo $< -pdf $@ 2>&1 | \

Shouldn't "CLANG" be "LANG"?

> +	awk 'BEGIN{err=0}{print}/not available in font/{err=1}END{exit err}' 1>&2  || \
> +	(echo "Found characters that cannot be displayed in PDF" 1>&2;  exit 1)

Currently "make postgres*.pdf" generates the pdf file even if there's
a "not available in font" error while generating it. With the patch
the pdf file is removed in this case. I'm not sure if this is an
improvement because there's no way to generate such a pdf file if
there's such a warning. Printing "Found characters that cannot be
displayed in PDF" is good, but I'd prefer let users decide whether
they retain or remove the pdf file.

> Subject: [PATCH v3 3/3] Check whether iconv exists for detecting non-latin1
>  characters
> 
> ---
>  configure              | 65 ++++++++++++++++++++++++++++++++++++++----
>  configure.ac           |  1 +
>  doc/src/sgml/Makefile  |  6 +++-
>  src/Makefile.global.in |  1 +

You don't need to include the patch for configure. Committer will
generate configure when it gets committed. See the discussion:
https://www.postgresql.org/message-id/20241126.102906.1020285543012274306.ishii%40postgresql.org

Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp