Feedback-ID: ia2694551:Fastmail
Date: Wed, 27 Nov 2024 16:57:35 +0100
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Bruce Momjian <bruce@momjian.us>
Cc: Nathan Bossart <nathandbossart@gmail.com>,
	Magnus Hagander <magnus@hagander.net>,
 Corey Huinker <corey.huinker@gmail.com>,
	Jeff Davis <pgsql@j-davis.com>, jian he <jian.universality@gmail.com>,
	Matthias van de Meent <boekewurm+postgres@gmail.com>,
 Tom Lane <tgl@sss.pgh.pa.us>, Stephen Frost <sfrost@snowman.net>,
	Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
 Peter Smith <smithpb2250@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Statistics Import and Export
Message-ID: <202411271557.gaewckwu64dm@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <Z0c_INg71CC_QmU5@momjian.us>
Archived-At: 
 <https://www.postgresql.org/message-id/202411271557.gaewckwu64dm%40alvherre.pgsql>
Precedence: bulk

On 2024-Nov-27, Bruce Momjian wrote:

> On Wed, Nov 27, 2024 at 09:18:45AM -0600, Nathan Bossart wrote:

> > > Maybe not remove the option, but add a required parameter:
> > > --analyze-in-stages=all / missing
> > > 
> > > That way, if the option is missing, the user can adapt the command line
> > > according to need.
> > 
> > I like this idea.
> 
> Would there be a default?

There would be no default.  Running with no option given would raise an
error.  The point is: you want to break scripts currently running
--analyze-in-stages so that they can make a choice of which of these two
modes to run.  Your proposal (as I understand it) is to remove the
--analyze-in-stages option and add two other options.  My proposal is to
keep --analyze-in-stages, but require it to have a specifier of which
mode to run.  Both achieve what you want, but I think mine achieves it
in a cleaner way.

> Uh, do we have parameters that require a boolean option like this? 

I'm not sure what exactly are you asking here.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"La gente vulgar sólo piensa en pasar el tiempo;
el que tiene talento, en aprovecharlo"