Feedback-ID: ia2694551:Fastmail
Date: Thu, 5 Dec 2024 15:43:08 +0100
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Kirill Reshke <reshkekirill@gmail.com>
Cc: jian he <jian.universality@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, 
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: attndims, typndims still not enforced, but make the value within
 a sane threshold
Message-ID: <202412051443.honqx6sa5nz3@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CALdSSPiNPB78tvH2Z2vFT3STwyV5j99dNLataW5c28AOMcMh_Q@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/202412051443.honqx6sa5nz3%40alvherre.pgsql>
Precedence: bulk

On 2024-Dec-05, Kirill Reshke wrote:

> On Fri, 20 Sept 2024 at 07:11, jian he <jian.universality@gmail.com> wrote:
> > attached patch removes attndims and typndims entirely.
> 
> LGTM?
> I see no open items in this thread. Are there any issues about v1?

Should we leave TupleDescInitEntry()'s API alone, to avoid breaking the
compilation of every extension in the world?  Maybe we could rename the
function (say to TupleDescInitializeEntry()) and use a define?

#define TupleDescInitEntry(a,b,c,d,e,f) TupleDescInitializeEntry(a,b,c,d,e)

Then the amount of churn is reduced, no extensions are broken, and we
can remove the define in a few years.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"Debido a que la velocidad de la luz es mucho mayor que la del sonido,
 algunas personas nos parecen brillantes un minuto antes
 de escuchar las pelotudeces que dicen." (Roberto Fontanarrosa)