Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tLg1b-00GIu9-5F for pgsql-hackers@arkaria.postgresql.org; Thu, 12 Dec 2024 10:02:27 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tLg1Y-009c4u-5z for pgsql-hackers@arkaria.postgresql.org; Thu, 12 Dec 2024 10:02:25 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tLg1X-009c3n-EC for pgsql-hackers@lists.postgresql.org; Thu, 12 Dec 2024 10:02:25 +0000 Received: from fhigh-b8-smtp.messagingengine.com ([202.12.124.159]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tLg1R-002QEE-Qo for pgsql-hackers@lists.postgresql.org; Thu, 12 Dec 2024 10:02:23 +0000 Received: from phl-compute-06.internal (phl-compute-06.phl.internal [10.202.2.46]) by mailfhigh.stl.internal (Postfix) with ESMTP id CE0C62540239; Thu, 12 Dec 2024 05:02:15 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Thu, 12 Dec 2024 05:02:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; t=1733997735; x=1734084135; bh=R /L4JB0Wm618kNOxxxgWUfpIPqVCZpJ0GK7243JGWpU=; b=aoueup3amVr3kcCPH Ldl3zLRZNzrE1+w/hIdtYVIbFYEqBrh669sIzvbomZ/mjLW/Qq/eGYEmYlMUEGAZ iYotNiPK4Er7Ic1siSggbBPg/Y77P+A+RZ/twhsd6VEa/oRUEn1ALvkV3/Ds8fzQ HxtiT8vtgnUPDDDb/ybsp59G3ypbftGmBwna+LuTI0o5cxHQ7rro23tmhhHbCmTu KuWe9nLYy8pBWkLUk4euy2iM3xJznPBMTKXwhgze3Y6wXEva9YPE963SHnNRP7gZ tORTzNhiEyyoB8+DbkRFF2wEh2lKGDe3fWY2W3wVnZZCfye+ZvX71SVfUujPIQ0l e+MTg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrkeehgddtlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpeffhffvvefukfggtggugfgjsehtkeertddttdejnecu hfhrohhmpeetlhhvrghrohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrd hnohdqihhprdhorhhgqeenucggtffrrghtthgvrhhnpedvkedtffduffdtffffheffhfej jefhgfeiueeukeejkeffgfdufffhudffffeuveenucffohhmrghinhepvghnthgvrhhprh hishgvuggsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomheprghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrghdpnhgspghrtg hpthhtohepgedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepshhmihhthhhpsgdv vdehtdesghhmrghilhdrtghomhdprhgtphhtthhopehpghhsqhhlqdhhrggtkhgvrhhsse hlihhsthhsrdhpohhsthhgrhgvshhqlhdrohhrghdprhgtphhtthhopehmihgthhgrvghl sehprghquhhivghrrdighiiipdhrtghpthhtohepthhglhesshhsshdrphhghhdrphgrrd hush X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 12 Dec 2024 05:02:15 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alvh.no-ip.org; s=schmee; t=1733997732; bh=1n4KYnsiic2dbJ8Lvj//XfGYd6TWuGm2On5goPl0ndQ=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=iaw+aiEQSajG4dMEr+386KTL38WcZ1Ds8mZffIHjj+uwR8MkAeqP1Q2F7s6EHStce ashpkC7Jg/98feQXFztHFWphkrTBiJjUY++GYzMcZsB9YwY4WrJ3hXBxJmaYpvzSol mZAjKy9eYq9RQ77Uw18fSuQzZ4Iw0Q9+Q01yVVSx0igbI3F+l6Gopbo7CFCjXqRmEv QrbdpgYaYsBcHwx8aS28F7HMELG+HK6325EoK9bZcFOsQwaBdamwtzepBLVe3/GWhH a9/KasSemJ5nLS3Jtq2pbFFWM9aUCIOP2zr2loa+/j8lBLiuK/8IXWvCeMU5h05Q2e d7D/8AurhfVSA== Received: by schmee.alvh.no-ip.org (Postfix, from userid 1000) id AB8549E; Thu, 12 Dec 2024 11:02:12 +0100 (CET) Date: Thu, 12 Dec 2024 11:02:12 +0100 From: Alvaro Herrera To: Michael Paquier Cc: Peter Smith , Tom Lane , PostgreSQL Hackers Subject: Re: pg_createsubscriber TAP test wrapping makes command options hard to read. Message-ID: <202412121002.2tsxty5t3ip2@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2024-Dec-12, Michael Paquier wrote: > On Thu, Dec 12, 2024 at 03:24:42PM +1100, Peter Smith wrote: > > PSA v2-0001. This time it can survive pgperltidy unchanged. > > Confirmed. It looks to apply cleanly to v17 as well. Better to > backpatch to avoid conflict frictions, even if it's cosmetic. I'd rather use #<<< and #>>> markers. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/