Feedback-ID: ia2694551:Fastmail
Date: Sat, 14 Dec 2024 13:43:46 +0100
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Subject: strangely worded message
Message-ID: <202412141243.efesjyyvzxsz@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/202412141243.efesjyyvzxsz%40alvherre.pgsql>
Precedence: bulk

Hello

The following message introduced by commit 03734a7fed7d appears in two
places:

        if (returning->typid != JSONOID && returning->typid != JSONBOID)
            ereport(ERROR,
                    (errcode(ERRCODE_DATATYPE_MISMATCH),
                     errmsg("cannot use RETURNING type %s in %s",
                            format_type_be(returning->typid), fname),
                     parser_errposition(pstate, output->typeName->location)));

where fname is either JSON(), JSON_SCALAR(), JSON_SERIALIZE().  The
wording seems a bit off to me.  What about the following?

ERROR:  cannot use type %s in RETURNING clause of %s
DETAIL:  Only types json and jsonb are allowed in the RETURNING clause.

Other ideas I considered:

ERROR:  cannot use RETURNING %s in %s
ERROR:  cannot use "RETURNING %s" in %s

DETAIL:  The type can be json or jsonb in RETURNING.
DETAIL:  The RETURNING clause allows types json or jsonb.
DETAIL:  Types json and jsonb are allowed in RETURNING.

Thanks

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/