Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tVBvm-006Gr2-LQ for pgsql-hackers@arkaria.postgresql.org; Tue, 07 Jan 2025 15:55:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tVBvl-005EtU-Vs for pgsql-hackers@arkaria.postgresql.org; Tue, 07 Jan 2025 15:55:45 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tVBvl-005EtM-5t for pgsql-hackers@lists.postgresql.org; Tue, 07 Jan 2025 15:55:45 +0000 Received: from fout-a7-smtp.messagingengine.com ([103.168.172.150]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tVBvh-000Mvj-0Y for pgsql-hackers@lists.postgresql.org; Tue, 07 Jan 2025 15:55:44 +0000 Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfout.phl.internal (Postfix) with ESMTP id CE3A213801EC; Tue, 7 Jan 2025 10:55:39 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-11.internal (MEProxy); Tue, 07 Jan 2025 10:55:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1736265339; x=1736351739; bh=k CFfsWWbP42P7BBn2u8hBKpEcjSsIpgtzhS80IT3CqA=; b=okSe2KP4KhurKxfGN 9Y5EIM4PLY+4m/Zi8ROTZsZYoQIITanTFwkq5UCWwgb5DF4+h0NkOXDy1Tv0gRHW EHv29wvcMXCi2i9pe4x6R2lm50eiZPZNI4q2MHRWr8HELH/ln233NFiyLA5WXUuw XX0Ln8xjeHa7Y5mujksNrsdc3p3Al2NPoqlCNlrdLFHZVfroaVN/uVanTP1ZeHOO M5C7sNFboHzBdd+twxKBES7rStqLbvGyT5PFYDjUNtZQLwxlUFO5c0S4/fXp0OB1 te74tSCdbgA0s/m7meLmQQqIFoY1T90y2sXAJIR/L81f36W0yM1H9cdl9HX8+EL1 Hr3xQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrudegvddgkedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepfffhvfevuffkgggtugfgjgesthekredttddtjeen ucfhrhhomheptehlvhgrrhhoucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsegrlhhvhh drnhhoqdhiphdrohhrgheqnecuggftrfgrthhtvghrnhepvdektdffudfftdffffehfffh jeejhffgieeuueekjeekfffgudffhfduffffueevnecuffhomhgrihhnpegvnhhtvghrph hrihhsvggusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgr ihhlfhhrohhmpegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgpdhnsggprh gtphhtthhopeegpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehjihgrnhdruhhn ihhvvghrshgrlhhithihsehgmhgrihhlrdgtohhmpdhrtghpthhtohepthhnughrfigrnh hgsehgmhgrihhlrdgtohhmpdhrtghpthhtohepphhgshhqlhdqhhgrtghkvghrsheslhhi shhtshdrphhoshhtghhrvghsqhhlrdhorhhgpdhrtghpthhtohepthhglhesshhsshdrph hghhdrphgrrdhush X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 7 Jan 2025 10:55:39 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alvh.no-ip.org; s=schmee; t=1736265337; bh=FZuEM9e7PewjGy+ugPsq/FYipEqsz7OuvpNnVf0Cg1Q=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=OxtUzXonU8DFv04BU9HWEKq+1scEPRUg1li3sMMB45KwIR+0lKpE7h7Awr+GG/hAA KXQKZIN0jtfIy2rq4ddnp7EP9KrRSTfnyel0yVS6T59hruPolJD6B/bsNEc5V/NSGw ng+P760EY+wsBgsWXZMRvIDu+ylWTQHl9BBMNd6ZaevivKrsGuhIWSVPMp7q2RClbh 338E3FbqQhMhhBNYMvT6HJuAzSI9T8VsdPWfORtkqY3r/vM3Co75GE6HB8HmO1kNoB BIwsb9kAH79NHCTwQFco+1vO4kFLBvth07KJClV3XZtBo7iK1dZe9Vh0o3lMNzBT32 SFPjAR3gf6TtA== Received: by schmee.alvh.no-ip.org (Postfix, from userid 1000) id A28F58A; Tue, 7 Jan 2025 16:55:37 +0100 (CET) Date: Tue, 7 Jan 2025 16:55:37 +0100 From: Alvaro Herrera To: jian he Cc: Tom Lane , Pg Hackers , Tender Wang Subject: Re: not null constraints, again Message-ID: <202501071555.mpocpbw2qmtv@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2024-Dec-12, jian he wrote: > patch attached. > > also change comments of heap_create_with_catalog, > StoreConstraints, MergeAttributes. > so we can clear idea what's kind of constraints we are dealing with > in these functions. Great catch! The patch looks good, I have pushed it. Thank you. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ "Pido que me den el Nobel por razones humanitarias" (Nicanor Parra)