public inbox for [email protected]  

help / color / mirror / Atom feed

From: Alvaro Herrera <[email protected]>
To: Hunaid Sohail <[email protected]>
Cc: Dean Rasheed <[email protected]>
Cc: Sami Imseih <[email protected]>
Cc: David G. Johnston <[email protected]>
Cc: Maiquel Grassi <[email protected]>
Cc: [email protected] <[email protected]>
Cc: Jim Jones <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Nathan Bossart <[email protected]>
Cc: Imseih (AWS), Sami <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Pavel Luzanov <[email protected]>
Cc: Erik Wienhold <[email protected]>
Subject: Re: Psql meta-command conninfo+
Date: Tue, 14 Jan 2025 09:51:45 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAMWA6yaO82QyW0p3_38QdVykvFT=qWfcjPxOFam10SW_tOyt-w@mail.gmail.com>

On 2025-Jan-14, Hunaid Sohail wrote:

> I'm not attaching the patch as it requires some formatting.

Remember pgindent formats code in bulk.  A quick useful workflow is to
do that first, apply manual adjustments next, run pgindent again
afterwards.

> I've tried the approach and attached the output.  Does this look good?

Hmm, I'm not sure I like the third column particularly; it's noisy to
have on all the time.  I'd leave that for \conninfo++ maybe :-)

_If_ we keep the descriptions, I suggest that the majority need to be
very short, say three words tops, with exceptions allowed for egregious
cases (if any).  We should get rid of filler words such as "Displays
the" or "Indicates whether".  For instance, I'd turn "Indicates if
GSSAPI authentication was used for the connection" into "GSSAPI
authenticated?" which conveys exactly the same; the ending "?" matches
things like "Key?" in \d of an index or the "Default?" column in \dc.
It's a boolean, so people know how to read it.

> I was wondering how we can show the descriptions of parameters
> from PQparameterStatus. We can create an array of descriptions,
> but if the order changes somehow, it can mess things up.

Definitely avoid writing code that can easily be broken by later changes
(future parameter additions and so on).

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"The problem with the facetime model is not just that it's demoralizing, but
that the people pretending to work interrupt the ones actually working."
                  -- Paul Graham, http://www.paulgraham.com/opensource.html

view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Psql meta-command conninfo+
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox