Feedback-ID: ia2694551:Fastmail
Date: Mon, 20 Jan 2025 12:40:03 +0100
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Sami Imseih <samimseih@gmail.com>
Cc: Hunaid Sohail <hunaidpgml@gmail.com>, pgsql-hackers@postgresql.org, 
	"David G. Johnston" <david.g.johnston@gmail.com>, Maiquel Grassi <grassi@hotmail.com.br>, 
	Jim Jones <jim.jones@uni-muenster.de>, Tom Lane <tgl@sss.pgh.pa.us>, 
	Nathan Bossart <nathandbossart@gmail.com>, "Imseih (AWS), Sami" <simseih@amazon.com>, 
	Peter Eisentraut <peter@eisentraut.org>, Pavel Luzanov <p.luzanov@postgrespro.ru>, 
	Erik Wienhold <ewie@ewie.name>, Dean Rasheed <dean.a.rasheed@gmail.com>
Subject: Re: Psql meta-command conninfo+
Message-ID: <202501201140.wt4nbx5y2dyl@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAA5RZ0uFqSxUbY67rFUX6+32Y384fzMigN7ybQ=orvQOquBLDA@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/202501201140.wt4nbx5y2dyl%40alvherre.pgsql>
Precedence: bulk

On 2025-Jan-17, Sami Imseih wrote:

> > Wait a second, why do we have these here?  Aren't they already in
> > \dconfig?
> 
>  \dconfig is generated by querying pg_settings and this
> requires a halthy connection. The parameters being proposed with
> \conninfo+ are set in libpq by the server [1] and can be retrieved
> even if the connection breaks.
> 
> Some of these parameters may overlap \dconfig, but I don't see
> that as a problem.

I feel the need to step back and ask, what problem are we solving here?
Your explanation isn't wrong, but I'm not sure why does a psql user need
all these.

I think you wanted to display "is_superuser" and that seems sensible in
the context of \conninfo+, and perhaps even "role" and "in_hot_standby"
would make sense; but the rest of the parameters that libpq stores do
not seem terribly interesting or relevant here.


That leads me to also wonder why don't we change \conninfo to have this
tabular behavior instead of creating a separate command for it.  Why do
we need to keep the existing form of \conninfo?  To me it seems strictly
less useful, as it is harder to read.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"Nunca se desea ardientemente lo que solo se desea por razón" (F. Alexandre)