Feedback-ID: ia2694551:Fastmail
Date: Tue, 21 Jan 2025 22:06:14 +0100
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@alvh.no-ip.org>
To: Amul Sul <sulamul@gmail.com>
Cc: 
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Subject: Re: Allow NOT VALID foreign key constraints on partitioned tables.
Message-ID: <202501212106.2wbouzfk56mb@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAAJ_b95pjru9JxU4Ve8yRFSCPO8VNmur8jfuHrACWuTBDt97zg@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/202501212106.2wbouzfk56mb%40alvherre.pgsql>
Precedence: bulk


Suppose I have a hierarchy like this

      parent
        |
      child
       /\
      /  \
     /    grandchild2
    /
  grandchild1

and I have a validated constraint on grandchild1 and an invalid
constraint on child.  What happens if I add a constraint on parent?  In
my understanding, it should not attempt to revalidate the constraint on
grandchild1, because it's known valid; but I don't think I see code that
would skip validation there.  That is, QueueFKConstraintValidation does
its thing unconditionally (esp. recursing to children), which seems
wrong.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"I am amazed at [the pgsql-sql] mailing list for the wonderful support, and
lack of hesitasion in answering a lost soul's question, I just wished the rest
of the mailing list could be like this."                               (Fotis)
              https://postgr.es/m/200606261359.k5QDxE2p004593@auth-smtp.hol.gr