Date: Thu, 23 Jan 2025 15:27:41 +0900 (JST)
Message-Id: <20250123.152741.1191357484211664332.ishii@postgresql.org>
To: krasiyan@gmail.com
Cc: ojford@gmail.com, tgl@sss.pgh.pa.us, vik@postgresfriends.org,
 pgsql-hackers@postgresql.org, andrew@tao11.riddles.org.uk, david@fetter.org
Subject: Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options
From: Tatsuo Ishii <ishii@postgresql.org>
In-Reply-To: <CAN1PwokSDfSkOmDk6sfdEOUz_mTm333-gkLOBPK=JrVsMJFZ1g@mail.gmail.com>
References: <CAN1PwokRpv1fXMTjuqSVwEpNytXQW_EGwDfkanJUHXJFG0CCbQ@mail.gmail.com>
	<20250123.132502.1946260197628893279.ishii@postgresql.org>
	<CAN1PwokSDfSkOmDk6sfdEOUz_mTm333-gkLOBPK=JrVsMJFZ1g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/20250123.152741.1191357484211664332.ishii%40postgresql.org>
Precedence: bulk

> Hi,
> I was able to reproduce exactly the problem, with clean compile
> and --enable-cassert:
> test=# SELECT x,y,lead(y) IGNORE NULLS OVER (ORDER BY x) FROM
> (VALUES(1,NULL),(2,2),(3,NULL)) AS v(x,y);
>  x | y | lead
> ---+---+------
>  1 |   |    2
>  2 | 2 |    2
>  3 |   |    2
> (3 rows)
> 
> test=#
> Also, make check errors out at window test (without --enable-cassert it was
> passed in previous compile):

Yeah, same here.

Another possible problem is, probably the code does not work well if
there are multiple partitions. Since win_nonnulls stores currentpos in
a partition, when the partition ends, win_nonnulls needs to be
reset. Otherwise, it mistakenly represents currentpos in the previous
partition.

Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp