Date: Thu, 23 Jan 2025 19:22:20 +0900
From: Yugo NAGATA <nagata@sraoss.co.jp>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: Nathan Bossart <nathandbossart@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
 pgsql-hackers@postgresql.org
Subject: Re: Extend ALTER DEFAULT PRIVILEGES for large objects
Message-Id: <20250123192220.9bad2b9aec110bf335521276@sraoss.co.jp>
In-Reply-To: <9c0c4d7881d2450baf70edb0ae95415a81ac8cb1.camel@cybertec.at>
References: <20240424115242.236b499b2bed5b7a27f7a418@sraoss.co.jp>
	<3602391.1713930458@sss.pgh.pa.us>
	<20240424210839.GA863220@nathanxps13>
	<20240426175406.13e47ea3904de814afbfe496@sraoss.co.jp>
	<20240913161801.b1e60534d77fa9df447b775f@sraoss.co.jp>
	<9c0c4d7881d2450baf70edb0ae95415a81ac8cb1.camel@cybertec.at>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?RLOBAXo54t8HJBrSToZJnL4M1IdpoZd0tr6LF7xIqhB8DTzds/YJHKpC9pPM?=
 =?us-ascii?Q?Yoh8/VYYtvTEq4C9g4dorNFgdAmeT7eikKnuKLfHMbT6Xp3Jf2JcC7JoBA8t?=
 =?us-ascii?Q?0C260lsVeHKruAO0Pbn+E+URYBbC6j2RcOHLk024K4/0Bq0PLCpz8H8tjyoK?=
 =?us-ascii?Q?qtE4y8XFKaPW51hfrcdCkwXBwZXA+IyrSJAmcIbDUzzN0+8rZ0A50gdLFDUU?=
 =?us-ascii?Q?r7Ei3MQ5NfQ57E7ix/wp9leXJJhDHNad8JeIWNM8Llsu/NkvtCTZyEYMQHv+?=
 =?us-ascii?Q?GpzOLcc1Sscm3KgS8q7/4CooYVkNP4FkvP6o1tNE9OUcUEAzxcUa/yG17hpY?=
 =?us-ascii?Q?1VfxHR4uuX2vs5M6d2kM368fU9xYm1VWQbOeJhskgg1WvozjH3vMXE10H0FA?=
 =?us-ascii?Q?0Nve2YoQCQgj/AvxftkYMIeEtbpjOVj+aoANm56Cnk4kWkFMV9T8STqR1DGU?=
 =?us-ascii?Q?lCiF0XU3qSYTd26AzcSWCf69Xv+JqAU6bE4ysT1AzA1ZuK9CvuboFl4o7IG2?=
 =?us-ascii?Q?1LUlsBSAmrv/wP7g4hbymJiUFyz5+IfS9KmzWRDKgAjIAC0eCoZmacvm0L09?=
 =?us-ascii?Q?R3Zzx+Z7aQp9FjPOAB71gvjRUcJ0AoHBfrl5NOnqSzcIS/P1V6CABK3AmIvC?=
 =?us-ascii?Q?4pahiwmhPal/dno0xjTHY5GUdjJu3lRIhtLp9yjE3nLCMQb+zOlurc7C3t6M?=
 =?us-ascii?Q?wvI6dOi/bSVyV3j+6Qs2wWwqefCNMnbF0c+Sl8jlAmqNQjqRVbMnE7gsFO79?=
 =?us-ascii?Q?zlZb/e7ZOy0v0EAnS+dW40dG18SXpilm3qe4soYV3h1BXBdTa/POqfACPQMn?=
 =?us-ascii?Q?NSot8gQrz+J2fcxa6MCCR6LmSSq9jrWG+VC61GHeCaII+A9x94kELTGrnZh4?=
 =?us-ascii?Q?3/pWEF+11AqDhZd+g3WCL10PSyuxUU4lfUVhrReaFt1FxF2so3JTYwAqmC1Y?=
 =?us-ascii?Q?UvTuyF0S/h4LsaciPd3IHT+FYHEODmYu5v5OAMB8dTH4w+dqTmqIis69CG0q?=
 =?us-ascii?Q?NgoO4XFj6YwZYjndpN/28IqNXWhoin1djiZ00Z8Y5i0CdLlnYCw2nPSm9XFX?=
 =?us-ascii?Q?pgLkTIFZOqnLY+525b0XWkpsVugob2I8ZoEbu2V1z5Hr5FYLZP3S41oLS3ww?=
 =?us-ascii?Q?uu/LTfvzFbsnay0BPwZIL00AcLwZzK+M/Nc3DqcFEYrwS4kqA8qTC5aV4/Ti?=
 =?us-ascii?Q?Z0BU9XUCo05teePV/M1KRGdTILdk+v5u70d8mdSKnn7T8/lxksfrXajt0ZsA?=
 =?us-ascii?Q?RMvJHQq6WX5eC21asfnXU2ZBF0zB6bdczSeYtkczuXQoGumZYlWemdXxJzkP?=
 =?us-ascii?Q?6Q3eC8gS7y7y8kbJsnco8xUour0PngNIME6Dmbf23/AyYsKSeNsr0EmAZ25R?=
 =?us-ascii?Q?MUxF1cEP3N+MkNEijEBLMsTqf+Ufy8eU972gQqir8Svjsdpsx+SDpxq4I7PK?=
 =?us-ascii?Q?N2dBwLXqjbUCs7CT3tHBpYmRnVwz/1qgKWSluXlOf4LNkXSlZ7FunA0Q/VY1?=
 =?us-ascii?Q?QXEaA/LpmZyNhUghLh7oEeoxCotsdt8wNamTYymllE+yTxEqRTY1ePxn2h+C?=
 =?us-ascii?Q?A394uZPq/EuzzN1K7JhJgBYzU6UC3oC5v3ZfJeSMByK6jpWbcvH5QwfhRl0T?=
 =?us-ascii?Q?lbOXb2y54GUwZXoSrc5ntjxToPc+NYa2qNSpVVLcaAHa?=
X-OriginatorOrg: sraoss.co.jp
X-MS-Exchange-CrossTenant-Network-Message-Id: 652f9529-0b4a-476e-b183-08dd3b97f03a
X-MS-Exchange-CrossTenant-AuthSource: OSYP286MB0102.JPNP286.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2025 10:23:11.6123
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 75db6c32-352e-4063-ae79-cafb8623f6db
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6pCgg0TLsL2OgWr6L3H1rS4BYj6RhDVQMQ/TL1kpb9blFof+8PoeSNQIW8svd4qPEOD8CnKtNVNZ72PcQXTvzQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWP286MB3479
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/20250123192220.9bad2b9aec110bf335521276%40sraoss.co.jp>
Precedence: bulk

On Wed, 22 Jan 2025 13:30:17 +0100
Laurenz Albe <laurenz.albe@cybertec.at> wrote:

> On Fri, 2024-09-13 at 16:18 +0900, Yugo Nagata wrote:
> > I've attached a updated patch. The test is rewritten using has_largeobject_privilege()
> > function instead of calling loread & lowrite, which makes the test a bit simpler.
> > Thare are no other changes.
> 
> When I tried to apply this patch, I found that it doesn't apply any
> more since commit f391d9dc93 renamed tab-complete.c to tab-complete.in.c.
> 
> Attached is a rebased patch.

Thank you for updating the patch!

> I agree that large objects are a feature that should fade out (alas,
> the JDBC driver still uses it for BLOBs).  But this patch is not big
> or complicated and is unlikely to create a big maintenance burden.
> 
> So I am somewhat for committing it.  It works as advertised.
> If you are fine with my rebased patch, I can mark it as "ready for
> committer".  If it actually gets committed depends on whether there
> is a committer who thinks it worth the effort or not.

I confirmed the patch and I am fine with it.

Regards,
Yugo Nagata

-- 
Yugo NAGATA <nagata@sraoss.co.jp>