Feedback-ID: ia2694551:Fastmail
Date: Mon, 3 Feb 2025 08:57:21 +0100
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@alvh.no-ip.org>
To: Sergey Tatarintsev <s.tatarintsev@postgrespro.ru>
Cc: Melanie Plageman <melanieplageman@gmail.com>, 
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgbench with partitioned tables
Message-ID: <202502030757.muvzlswbtfuh@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2d4bd03d-1767-4471-9488-623f7fb7a981@postgrespro.ru>
Archived-At: <https://www.postgresql.org/message-id/202502030757.muvzlswbtfuh%40alvherre.pgsql>
Precedence: bulk

On 2025-Feb-03, Sergey Tatarintsev wrote:

> Thanks for the note. I changed the query in the patch (v2 patch attached)
> 
> Btw, an additional benefit from the patch is that we can use foreign tables
> (for example, to test postgres_fdw optimizations)

Good thought, and maybe it would be better if the new function was
"get_table_relkind" which just returns the char, and this check

> +	/* Use COPY with FREEZE on v14 and later for all regular tables */
> +	if ((PQserverVersion(con) >= 140000) && is_regular_table(con, table))
>  			copy_statement_fmt = "copy %s from stdin with (freeze on)";

can be "&& get_table_relkind(con, table) == RELKIND_RELATION"

which I think is more natural.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/