Feedback-ID: ia2694551:Fastmail
Date: Sat, 8 Feb 2025 11:32:58 +0100
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@alvh.no-ip.org>
To: Melanie Plageman <melanieplageman@gmail.com>
Cc: Sergey Tatarintsev <s.tatarintsev@postgrespro.ru>, 
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgbench with partitioned tables
Message-ID: <202502081032.3q4n6a3uihw3@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAAKRu_bq3z7oQ4SQRh1EOMFque1xDDO_UdDub+d0XiE4rpGrtw@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/202502081032.3q4n6a3uihw3%40alvherre.pgsql>
Precedence: bulk

On 2025-Feb-07, Melanie Plageman wrote:

> Okay, I've stared at this a bit, and it seems basically fine the way
> it is (I might add a bit more whitespace, clean up the commit message,
> etc). So I'm interested in committing it. I will admit that having
> never committed anything to pgbench, I'm a bit nervous. So, give me a
> couple days to work up the nerve.

Sounds good.  I only wanted to say that I would use PQexecParams()
instead of PQexec() in the new function, avoiding the psprintf and
pfree, and also that initializing relkind to RELKIND_RELATION is strange
and probably unnecessary.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"Cuando mañana llegue pelearemos segun lo que mañana exija" (Mowgli)