Feedback-ID: ia2694551:Fastmail
Date: Tue, 11 Feb 2025 13:14:52 +0100
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@alvh.no-ip.org>
To: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Kirill Reshke <reshkekirill@gmail.com>, Sergei Kornilov <sk@zsrv.org>, 
	yasuo.honda@gmail.com, tgl@sss.pgh.pa.us, smithpb2250@gmail.com, vignesh21@gmail.com, 
	michael@paquier.xyz, nathandbossart@gmail.com, stark.cfm@gmail.com, 
	geidav.pg@gmail.com, marcos@f10.com.br, robertmhaas@gmail.com, david@pgmasters.net, 
	pgsql-hackers@postgresql.org, pavel.trukhanov@gmail.com, Sutou Kouhei <kou@clear-code.com>
Subject: Re: pg_stat_statements and "IN" conditions
Message-ID: <202502111214.fcfodex6t3sy@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <75yd2qoe5heofyp7jj4anluvodxhhc3mhkmjgspnslkn4n2xcc@oisglqgxqkaw>
Archived-At: <https://www.postgresql.org/message-id/202502111214.fcfodex6t3sy%40alvherre.pgsql>
Precedence: bulk

Hello

I noticed something that surprised me at first, but on further looking
it should have been obvious: setting pg_stat_statements.query_id_const_merge
affects the query ID for all readers of it, not just pg_stat_statement.
This is good because it preserves the property that pg_stat_activity
entries can be matched to pg_stat_statement entries by query_id.

Looking to commit 0001 soon.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"On the other flipper, one wrong move and we're Fatal Exceptions"
(T.U.X.: Term Unit X  - http://www.thelinuxreview.com/TUX/)