Date: Tue, 18 Feb 2025 13:19:28 +0900 (JST)
Message-Id: <20250218.131928.503752198926696812.ishii@postgresql.org>
To: ojford@gmail.com
Cc: krasiyan@gmail.com, tgl@sss.pgh.pa.us, vik@postgresfriends.org,
 pgsql-hackers@postgresql.org, andrew@tao11.riddles.org.uk, david@fetter.org
Subject: Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options
From: Tatsuo Ishii <ishii@postgresql.org>
In-Reply-To: <CAGMVOdtq=Uu-dfLxP3oJQ5fWv=wSuqwGq3P_OFq=+DS6K5vv5Q@mail.gmail.com>
References: <CAGMVOdvkV38dW_PKjM+ULw9qtryobPPhYWTvJyxLa+QOfCeiQg@mail.gmail.com>
	<20250203.204555.1527524827386762643.ishii@postgresql.org>
	<CAGMVOdtq=Uu-dfLxP3oJQ5fWv=wSuqwGq3P_OFq=+DS6K5vv5Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/20250218.131928.503752198926696812.ishii%40postgresql.org>
Precedence: bulk

> Attached version doesn't use the nonnulls array if an Exclude is
> specified, as I think it's not going to work with exclusions (as it's
> only an optimization, this is ok and can be taken out entirely if you
> prefer). I've also added your tests above to the tests.

I applied the v7 patch and ran regression and tap test. There was no
errors. Great!

BTW, I noticed that in the code path where
ignorenulls_getfuncarginframe() is called, WinSetMarkPosition() is
never called?

Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp