public inbox for [email protected]  
help / color / mirror / Atom feed
From: Kyotaro Horiguchi <[email protected]>
To: [email protected]
Subject: Fix untranslatable split message
Date: Tue, 25 Feb 2025 14:09:53 +0900 (JST)
Message-ID: <[email protected]> (raw)

Hello,

The recent commit 1aab6805919 introduced a help description that was
split into two printf() commands, making it untranslatable.

The attached patch merges them into a single message.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center


Attachments:

  [text/x-patch] 0001-Merge-split-string-literals-into-a-single-message.patch (1.4K, ../[email protected]/2-0001-Merge-split-string-literals-into-a-single-message.patch)
  download | inline diff:
From f946b02bbb4e30bc250bf7386556c970ddb7dfbd Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi <[email protected]>
Date: Tue, 25 Feb 2025 13:57:03 +0900
Subject: [PATCH] Merge split string literals into a single message

A recently added option description was split across two output
commands, making the message untranslatable. Merge them into a single
message.
---
 src/bin/pg_upgrade/option.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/bin/pg_upgrade/option.c b/src/bin/pg_upgrade/option.c
index fe716c4c805..188dd8d8a8b 100644
--- a/src/bin/pg_upgrade/option.c
+++ b/src/bin/pg_upgrade/option.c
@@ -323,8 +323,8 @@ usage(void)
 	printf(_("  --copy                        copy files to new cluster (default)\n"));
 	printf(_("  --copy-file-range             copy files to new cluster with copy_file_range\n"));
 	printf(_("  --no-statistics               do not import statistics from old cluster\n"));
-	printf(_("  --set-char-signedness=OPTION  set new cluster char signedness to \"signed\" or\n"));
-	printf(_("                                \"unsigned\"\n"));
+	printf(_("  --set-char-signedness=OPTION  set new cluster char signedness to \"signed\" or\n"
+			 "                                \"unsigned\"\n"));
 	printf(_("  --sync-method=METHOD          set method for syncing files to disk\n"));
 	printf(_("  -?, --help                    show this help, then exit\n"));
 	printf(_("\n"
-- 
2.43.5



view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Fix untranslatable split message
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox