Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tn6qn-002AUg-0n for pgsql-hackers@arkaria.postgresql.org; Wed, 26 Feb 2025 02:08:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tn6ql-00ClY3-KS for pgsql-hackers@arkaria.postgresql.org; Wed, 26 Feb 2025 02:08:39 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tn6ql-00ClXc-AO for pgsql-hackers@lists.postgresql.org; Wed, 26 Feb 2025 02:08:39 +0000 Received: from mail.clear-code.com ([153.126.203.179]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tn6qf-0006Ow-2i for pgsql-hackers@postgresql.org; Wed, 26 Feb 2025 02:08:37 +0000 Received: from localhost (unknown [IPv6:2404:7a80:9f01:f500:acd0:2aa3:7b08:7206]) by mail.clear-code.com (Postfix) with ESMTPSA id AF98C684C5F; Wed, 26 Feb 2025 11:08:28 +0900 (JST) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.clear-code.com AF98C684C5F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=clear-code.com; s=default; t=1740535708; bh=LsaIpXZivF9bucUcBM6Yb8RsmKrNZlg1Bk1oUNzANsw=; h=Date:To:Cc:Subject:From:In-Reply-To:References:From; b=VGE1tbDZSh2m16AnRJ3YagAK7Gx9XHujY4wLWkUYq1Q5oZzpsLFQ/DOTtWZpxVsph G0S8JGI+R/7wFvpHNuqvVR0e7Yz0FkIfFVJsEgiApoOtDd+0uX4p6Cs4fmhVaVzbdo r2dyzJoIXtVxefgTtTU8rwhXqUOKMkCVVTYdSXVw= Date: Wed, 26 Feb 2025 11:08:26 +0900 (JST) Message-Id: <20250226.110826.297987517588158968.kou@clear-code.com> To: sawada.mshk@gmail.com Cc: michael@paquier.xyz, zhjwpku@gmail.com, pgsql-hackers@postgresql.org Subject: Re: Make COPY format extendable: Extract COPY TO format implementations From: Sutou Kouhei In-Reply-To: References: <20250226.085159.1492932557196528740.kou@clear-code.com> X-Mailer: Mew version 6.8 on Emacs 29.4 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: AF98C684C5F X-Rspamd-Server: mail.clear-code.com X-Spamd-Result: default: False [2.90 / 999.00]; SUSPICIOUS_RECIPS(1.50)[]; MID_CONTAINS_FROM(1.00)[]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[text/plain]; TAGGED_RCPT(0.00)[]; ARC_NA(0.00)[]; ASN(0.00)[asn:2518, ipnet:2404:7a80::/29, country:JP]; RCVD_COUNT_ZERO(0.00)[0]; MIME_TRACE(0.00)[0:+]; FREEMAIL_TO(0.00)[gmail.com]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[paquier.xyz,gmail.com,postgresql.org]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_NONE(0.00)[]; RCPT_COUNT_THREE(0.00)[4] X-Rspamd-Action: no action List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, In "Re: Make COPY format extendable: Extract COPY TO format implementations" on Tue, 25 Feb 2025 17:14:43 -0800, Masahiko Sawada wrote: > I've attached updated patches. Thanks. I found one more missing last ".": 0002: > --- a/src/backend/commands/copyfrom.c > +++ b/src/backend/commands/copyfrom.c > @@ -106,6 +106,145 @@ typedef struct CopyMultiInsertInfo > +/* > + * Built-in format-specific routines. One-row callbacks are defined in > + * copyfromparse.c > + */ copyfromparse.c -> copyfromparse.c. Could you push them? Thanks, -- kou