Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tpXmW-007Zta-6U for pgsql-hackers@arkaria.postgresql.org; Tue, 04 Mar 2025 19:18:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tpXmU-005jWw-TQ for pgsql-hackers@arkaria.postgresql.org; Tue, 04 Mar 2025 19:18:18 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tpXmU-005jWo-HW for pgsql-hackers@lists.postgresql.org; Tue, 04 Mar 2025 19:18:18 +0000 Received: from fout-a6-smtp.messagingengine.com ([103.168.172.149]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tpXmQ-000xCC-1b for pgsql-hackers@lists.postgresql.org; Tue, 04 Mar 2025 19:18:18 +0000 Received: from phl-compute-01.internal (phl-compute-01.phl.internal [10.202.2.41]) by mailfout.phl.internal (Postfix) with ESMTP id BF734138274F; Tue, 4 Mar 2025 14:18:14 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-01.internal (MEProxy); Tue, 04 Mar 2025 14:18:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; t=1741115894; x=1741202294; bh=y xpg9c62I+icd19c4qYPwfbippURyLE24a7BIxfpvMw=; b=xV4+2U/WQBjqZ8b11 QfZIf6T0A+XRdB1YxmAIe+GLUYgdL3y1h9iXqPOjhcsBQab/hZLIEhOi3AXyfVXa ulN5RbRgFnsinmZt2ynKnbf/KfhZDOXAk9T+/GMCFQ9+0RnqdizshYPfNDy553cj PgcjUmtkCWeoXP40+Ok8Zi018hTixqbuVJ9ySYlBEY0YjytTx5NaECOhMsOpuaBY 7DjPUwauAGuVDiYO2vpEXVFcdnz3ykWrhpk/ompGiQDx+xF4QnIPmexubcj2IzJ3 7kGVJA2iX6ic1td6xMd/aBoHEARR7Q6TAn26Z8EMAJy3UOUWYZTZmUCMOr6QAtQz cSk2g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddutddvkeeiucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhepfffhvfevuffkgggtugfgjgesthekredttddt jeenucfhrhhomheplmhlvhgrrhhoucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsegrlh hvhhdrnhhoqdhiphdrohhrgheqnecuggftrfgrthhtvghrnhepvdehueffhefgueekueef heehgffhuefgfedukeejveduffegffekgeffffevgeehnecuffhomhgrihhnpegvnhhtvg hrphhrihhsvggusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep mhgrihhlfhhrohhmpegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgpdhnsg gprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehnrghthhgr nhgusghoshhsrghrthesghhmrghilhdrtghomhdprhgtphhtthhopehpghhsqhhlqdhhrg gtkhgvrhhssehlihhsthhsrdhpohhsthhgrhgvshhqlhdrohhrgh X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 4 Mar 2025 14:18:14 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alvh.no-ip.org; s=schmee; t=1741115892; bh=7k5nvEEEhS/PM7BucJG4uDNzl1GCOmnd6ru9xV5UGts=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=Dvlt65NuMujFAU0mCo8yFGSS82bXnw39FCpFRSdnPtrZOru6+pgLteq8YnqIG0Vpn p2kbXb87e+Ddnrk079W86MG9LgsqLgjslX7323UkFL0etOt15ljuXn/iA0zPFgABEY d6SwSVH8IUCM4QAZO/RFlhlmkHgAiNbGJIkk79MMODX3xXe0lnCDqr+3YgCp9FEqkY 7iVFMDCFxdnAA9O95cpqNK1zqei/yuT/hp3KQQAYUBrEJv9XhIar3AbLJGfDlA6mDd sMpjIbLiRezFMXqX4yEP1YPmvaOWL3L/1IwhWsNa3M8olojaDzKgKid0RukGhzskFU ucOA/Gdj/AiJQ== Received: by schmee.alvh.no-ip.org (Postfix, from userid 1000) id CA69C8F; Tue, 4 Mar 2025 20:18:12 +0100 (CET) Date: Tue, 4 Mar 2025 20:18:12 +0100 From: =?utf-8?Q?=C3=81lvaro?= Herrera To: Nathan Bossart Cc: Pg Hackers Subject: Re: bogus error message for ALTER TABLE ALTER CONSTRAINT Message-ID: <202503041918.r7rssywqyv6a@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2025-Mar-04, Nathan Bossart wrote: > On Tue, Mar 04, 2025 at 07:22:22PM +0100, Álvaro Herrera wrote: > > I just discovered that trying to set a foreign key as NO INHERIT in > > ALTER TABLE ALTER CONSTRAINT returns an absurd error message: > > Here's the fix along with some additional cleanup. > > LGTM Many thanks for the quick look. Pushed now. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ Thou shalt check the array bounds of all strings (indeed, all arrays), for surely where thou typest "foo" someone someday shall type "supercalifragilisticexpialidocious" (5th Commandment for C programmers)