Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tqGJw-00234R-Mi for pgsql-hackers@arkaria.postgresql.org; Thu, 06 Mar 2025 18:51:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tqGJv-004Vne-EL for pgsql-hackers@arkaria.postgresql.org; Thu, 06 Mar 2025 18:51:47 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tqGJv-004VSV-1a for pgsql-hackers@lists.postgresql.org; Thu, 06 Mar 2025 18:51:47 +0000 Received: from fout-b7-smtp.messagingengine.com ([202.12.124.150]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tqGJp-001Llc-0i for pgsql-hackers@postgresql.org; Thu, 06 Mar 2025 18:51:44 +0000 Received: from phl-compute-13.internal (phl-compute-13.phl.internal [10.202.2.53]) by mailfout.stl.internal (Postfix) with ESMTP id 5853811400FB; Thu, 6 Mar 2025 13:51:40 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-13.internal (MEProxy); Thu, 06 Mar 2025 13:51:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; t=1741287100; x=1741373500; bh=v PKa9f8E+Y5giJUZ/Z9vgRgIMBhxUIP99kC+5SBr3T8=; b=zu2ZRSvEn3U7kysK2 hkZBe6Z1POx92Z7Ng5sdu8u5U0/u71Cq4uuX82yOTGuEf/fJj+o3jwUbIz6kVcg6 60H2rj7xn6rImSaZgA71qoV7F4xJj7+UkU7UUcYmM1L7vS7dQKXCJNAixXt7W8Vq yJQPSCglVKXSYpkRa0jCJOdQQNiCV1xx9beydVSjwBcvDyeHvXxRhc6OlrSzZkfZ GLUhgPxg/IdBEd9Jr7hGpHieLbWDoTnHW7XIEEo3Vn8ok63MH05jhMI5nS4mfAU/ qXnAsBY3M4mk5TX/U9tiNYSbMch5qj/gz/tDAlvKjQDb6yXS8wPKGvkHF9R6gBJW UZYNw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddutdekhedvucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhepfffhvfevuffkgggtugfgjgesthekredttddt jeenucfhrhhomheplmhlvhgrrhhoucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsegrlh hvhhdrnhhoqdhiphdrohhrgheqnecuggftrfgrthhtvghrnhepvdehueffhefgueekueef heehgffhuefgfedukeejveduffegffekgeffffevgeehnecuffhomhgrihhnpegvnhhtvg hrphhrihhsvggusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep mhgrihhlfhhrohhmpegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgpdhnsg gprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehrrghnihgv rhdrvhhfsehgmhgrihhlrdgtohhmpdhrtghpthhtohepphhgshhqlhdqhhgrtghkvghrsh esphhoshhtghhrvghsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 6 Mar 2025 13:51:39 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alvh.no-ip.org; s=schmee; t=1741287098; bh=Vkv4DwPkjrDh9c20yWRWn6oHNP/xs+eyDybNtgoyW7g=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=RCqMAG1HgHCcjlYHBrbwemSxK+UtU9GfUTFoO6WbEyFL0JcsPje2Lr3sVBR00L3Er T34k2L2ASYbN2lUcjw972zkZqESJ8WEPsAB7j0kkt07WMApDPIzb1fRQdW1FvyVsis AL2OkFfxVnJyxlzbUqAxJ6v1fpy5NPi6YMTeUIlr0LNzZnWzNYhD0GOUY1nB4gx4Kw gITJabprcvM2cS26PMBomZc2blfTQxnUv7KoZijSeorlHXL1E0G7IzrnxHwXuPklEc /cRK4Wp2EhxB/5FYd8+VX7idUADczbolQ+whK3ZelZm52h+miJ5x7GGBsTyX5Ipu7t tbRNrP5J/tWBQ== Received: by schmee.alvh.no-ip.org (Postfix, from userid 1000) id 4E9F38F; Thu, 6 Mar 2025 19:51:38 +0100 (CET) Date: Thu, 6 Mar 2025 19:51:38 +0100 From: =?utf-8?Q?=C3=81lvaro?= Herrera To: Ranier Vilela Cc: Pg Hackers Subject: Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c) Message-ID: <202503061851.cuxhyhb3gqwl@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2025-Feb-28, Ranier Vilela wrote: > v2 attached, please comment if you have any further objections. I think running the tests would have been a good idea, as would checking for compiler warnings. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ "I love the Postgres community. It's all about doing things _properly_. :-)" (David Garamond)