Date: Sun, 9 Mar 2025 10:23:55 -0700
From: Noah Misch <noah@leadboat.com>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org
Subject: Re: BackgroundPsql swallowing errors on windows
Message-ID: <20250309172355.05.nmisch@google.com>
References: <h6t2voqv6vm4xk4oh5q6og676h7ehv2opbvr2id7m2xot3adh5@t7su2dmuo3bs>
 <20250216184740.55.nmisch@google.com>
 <qo3x3ycl5fokh4tumm3lo6rn6ijvl7mmes7k24fm3kuv4xaupt@px4vl5ocnvth>
 <20250216223951.a3.nmisch@google.com>
 <684214.1739747924@sss.pgh.pa.us>
 <20250216235843.7c.nmisch@google.com>
 <695158.1739753418@sss.pgh.pa.us>
 <9D3BCBE0-5DC1-4344-A87E-74F6809F2FF8@anarazel.de>
 <20250217015236.62.nmisch@google.com>
 <pvdab7ndl3lurnirgwczglua4gwrtd4pwrnjz4dtzggbzhz42j@no4qnapl2nq6>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <pvdab7ndl3lurnirgwczglua4gwrtd4pwrnjz4dtzggbzhz42j@no4qnapl2nq6>
User-Agent: Mutt/2.2.12 (2023-09-09)
Archived-At: 
 <https://www.postgresql.org/message-id/20250309172355.05.nmisch%40google.com>
Precedence: bulk

On Sun, Mar 09, 2025 at 12:47:34PM -0400, Andres Freund wrote:
> On 2025-02-16 17:52:36 -0800, Noah Misch wrote:
> > On Sun, Feb 16, 2025 at 08:42:50PM -0500, Andres Freund wrote:
> > > On February 16, 2025 7:50:18 PM EST, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > > >Noah Misch <noah@leadboat.com> writes:
> > > >> On Sun, Feb 16, 2025 at 06:18:44PM -0500, Tom Lane wrote:
> > > >>> I think that
> > > >>> IPC::Run may be screwing up here, because I have seen non-Windows
> > > >>> CI failures that look like it didn't read all the stderr output.
> > > >>> For example, this pgbench test failure on macOS from [1]:
> > > >
> > > >> https://github.com/cpan-authors/IPC-Run/commit/2128df3bbcac7e733ac46302c4b1371ffb88fe14
> > > >> fixed that one.
> > > >
> > > >Ah.  Do we know whether that fix has made it into our CI images?
> > > >(Or anywhere else, for that matter?)
> > > 
> > > The CI images are regenerated three times a week, but for most OSs, they will only install perl modules via the applicable packaging method, so it'll depend on when they pick up that version.
> > > 
> > > On Windows cpan is used, so it should pick that new version fairly quickly if a release has been made.
> > > 
> > > On macos we can't currently use images, so we just cache all the installed
> > > macports packages. The cache is keyed by OS version and list of packages
> > > to be installed, with no other forced invalidation right now. So it's hard
> > > to predict when a new version of a package will be picked up and it will
> > > differ between git repositories.  I've been wondering whether the cached
> > > macports install should just be regularly generated instead, along the
> > > other ci images.
> > 
> > The change is not in a release yet.  We could have macos install IPC::Run from
> > github, or I could get a release cut so it can make its way to macports.
> 
> It'd be great if we could get a release.

Yep.  I put the tree in the necessary state, and I contacted the person on
2025-02-17 and again on 2025-03-04.  I'm scheduled to follow up again on
2025-03-11.

> I guess I can figure out the magic
> incantations to install it from git for CI

There's no need to build anything, so it suffices to do:

git clone https://github.com/cpan-authors/IPC-Run.git
export PERL5LIB=$PWD/IPC-Run/lib
# (or append, if you already have non-empty PERL5LIB)