Feedback-ID: ia2694551:Fastmail
Date: Tue, 11 Mar 2025 15:46:52 +0100
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@alvh.no-ip.org>
To: jian he <jian.universality@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	Pg Hackers <pgsql-hackers@lists.postgresql.org>,
 Peter Eisentraut <peter@eisentraut.org>,
	Nathan Bossart <nathandbossart@gmail.com>
Subject: Re: bogus error message for ALTER TABLE ALTER CONSTRAINT
Message-ID: <202503111446.3ht6hlgszavl@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CACJufxGaAdNfF+-x6ZNpvEv7mhmjfcdr9PN-ZsPYe=z-b4seUg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202503111446.3ht6hlgszavl%40alvherre.pgsql>
Precedence: bulk

On 2025-Mar-11, jian he wrote:

> but it's better to align CREATE DOMAIN with ALTER DOMAIN.
> For example, the following two logic should behave the same.
> 
> create domain d_int as int4 constraint nn1 not null initially immediate;
> alter domain d_int add constraint nn1 not null initially immediate;

Sure, they should.

> Also if we do not error out, then in the create_domain.sgml, alter_domain.sgml
> <synopsis> section we should include these "useless" keywords.

Yeah, I guess we should do that.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/