Date: Tue, 11 Mar 2025 18:23:15 -0700
From: Noah Misch <noah@leadboat.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Nathan Bossart <nathandbossart@gmail.com>,
	Andres Freund <andres@anarazel.de>,
	Robert Pang <robertpang@google.com>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, robertmhaas@gmail.com,
	pgsql-hackers@postgresql.org
Subject: Re: Back-patch of: avoid multiple hard links to same WAL file after
 a crash
Message-ID: <20250312012315.fd.nmisch@google.com>
References: <YsORtfT4+fXj/i1V@paquier.xyz>
 <CAJhEC04tBkYPF4q2uS_rCytauvNEVqdBAzasBEokfceFhF=KDQ@mail.gmail.com>
 <Z2L6e1w-xABVTBRR@nathan>
 <7chjz7zeigbsbt7nim4cj6zryflzcpy2lgenas3yh7cpvwf3gb@m6cwqzlvfd6q>
 <Z2Oy1Z2nMVmTM5L5@paquier.xyz>
 <20250306193013.36.nmisch@google.com>
 <Z8n7HopB0bb4_j19@nathan>
 <Z853yPDh1xNWssD_@paquier.xyz>
 <20250311205749.a8.nmisch@google.com>
 <Z9DZY8PVgXI3-b5j@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Z9DZY8PVgXI3-b5j@paquier.xyz>
User-Agent: Mutt/2.2.12 (2023-09-09)
Archived-At: 
 <https://www.postgresql.org/message-id/20250312012315.fd.nmisch%40google.com>
Precedence: bulk

On Wed, Mar 12, 2025 at 09:46:27AM +0900, Michael Paquier wrote:
> On Tue, Mar 11, 2025 at 01:57:49PM -0700, Noah Misch wrote:
> > Thanks for crafting back-branch versions.  I've queued a task to confirm I get
> > the same result.
> 
> Thanks for that.  That helps a lot.

I'll let you know when I get there.

> > There's a test case I'll polish, too.
> 
> Are you considering the addition of a TAP test in 17~ based on a wait
> injection point in the checkpointer coupled with a check of the server
> logs to see if we see the error patterns you've spotted?

No, nothing involving injection points or otherwise version-specific.