Feedback-ID: ia2694551:Fastmail
Date: Wed, 12 Mar 2025 19:34:16 +0100
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@alvh.no-ip.org>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: remove open-coded popcount in acl.c
Message-ID: <202503121834.nrw4lp5mwd7v@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <Z9HQHX21PVAK-xea@nathan>
Archived-At: 
 <https://www.postgresql.org/message-id/202503121834.nrw4lp5mwd7v%40alvherre.pgsql>
Precedence: bulk

On 2025-Mar-12, Nathan Bossart wrote:

> On Wed, Mar 12, 2025 at 05:23:25PM +0100, Álvaro Herrera wrote:
> > Strange: this code is not covered by any tests.
> > 
> > https://coverage.postgresql.org/src/backend/utils/adt/acl.c.gcov.html#5533
> > https://coverage.postgresql.org/src/backend/utils/adt/acl.c.gcov.html#5438
> 
> Huh.  Well, it's easy enough to add some basic tests for the grantor
> selection machinery.  Here's a first try.

Thanks :-)  I confirm that this covers the code in select_best_grantor
that you're modifying.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"Ed is the standard text editor."
      http://groups.google.com/group/alt.religion.emacs/msg/8d94ddab6a9b0ad3