public inbox for [email protected]
help / color / mirror / Atom feedFrom: Álvaro Herrera <[email protected]>
To: Amul Sul <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Pg Hackers <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Nathan Bossart <[email protected]>
Subject: Re: bogus error message for ALTER TABLE ALTER CONSTRAINT
Date: Fri, 14 Mar 2025 12:16:43 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAAJ_b97hd-jMTS7AjgU6TDBCzDx_KyuKxG+K-DtYmOieg+giyQ@mail.gmail.com>
On 2025-Mar-11, Amul Sul wrote:
> I was thinking of something like the attached, which includes your
> test cases from 0001. Perhaps the macro name could be improved.
FWIW I like this general idea. I don't like the proposed names much
though, especially the abuse of ALL_CAPS; and because they operate on
the given bits themselves rather than the output of processCASbits(), I
would have these checks before doing anything else. (Also, for nicer
code layout I would perhaps make the macros static inline functions.)
I'm going to stay away from this for a bit, as I think this is of
somewhat secondary importance.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Every machine is a smoke machine if you operate it wrong enough."
https://twitter.com/libseybieda/status/1541673325781196801
view thread (12+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: bogus error message for ALTER TABLE ALTER CONSTRAINT
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox