Feedback-ID: ia2694551:Fastmail
Date: Mon, 24 Mar 2025 11:37:20 +0100
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@alvh.no-ip.org>
To: jian he <jian.universality@gmail.com>
Cc: Masahiro Ikeda <ikedamsh@oss.nttdata.com>,
	Robert Treat <rob@xzilla.net>, pgsql-hackers@lists.postgresql.org
Subject: Re: Doc: fix the rewrite condition when executing ALTER TABLE ADD
 COLUMN
Message-ID: <202503241037.pjpyt5j7xrfs@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CACJufxGLcbFVS8xAC9OBPn0U_2YjKOiHLdmBrtds1j=5eA5MMA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202503241037.pjpyt5j7xrfs%40alvherre.pgsql>
Precedence: bulk

On 2025-Mar-24, jian he wrote:

> In the current development branch,
> virtual generated columns still do not support the domain.
> you can not change the generation expression if it contains a check
> constraint on it.
> so virtual generated columns don't need rewriting.
> 
> IMHO, the committed doc description didn't mention this exception.
> we need some text to cover this exception?

I'd add a note about these two things to the open items page, and wait
to see if we get some of these limitations fixed, so that if we don't,
we remember to note this limitation in the documentation.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"All rings of power are equal,
But some rings of power are more equal than others."
                                 (George Orwell's The Lord of the Rings)