Date: Tue, 25 Mar 2025 15:44:40 -0700
From: Noah Misch <noah@leadboat.com>
To: Andres Freund <andres@anarazel.de>
Cc: Thomas Munro <thomas.munro@gmail.com>, Antonin Houska <ah@cybertec.at>,
	pgsql-hackers@postgresql.org, Heikki Linnakangas <hlinnaka@iki.fi>,
	Robert Haas <robertmhaas@gmail.com>,
	Jakub Wartak <jakub.wartak@enterprisedb.com>,
	Jelte Fennema-Nio <postgres@jeltef.nl>
Subject: Re: AIO v2.5
Message-ID: <20250325224440.0f.nmisch@google.com>
References: <20250325004537.17.nmisch@google.com>
 <dbeeaize47y7esifdrinpa2l7cqqb67k72exvuf3appyxywjnc@7bt76mozhcy2>
 <20250325133321.54.nmisch@google.com>
 <nk5gyjsny6w222roebnj2f7oid3stqrbh4xj5ah3xkvz52borc@hedincoyhg43>
 <20250325155808.f7.nmisch@google.com>
 <5ons2rtmwarqqhhexb3dnqulw5rjgwgoct57vpdau4rujlrffj@3fls6d2mkiwc>
 <20250325193956.57.nmisch@google.com>
 <t2za3i3u7jg4hqcxpr4n6tjuwm2bwpuwva344yfz7tiw3mlim2@ookbzlxmeum6>
 <20250325201850.55.nmisch@google.com>
 <xp62aoh554ufuz64aizgozxxjc6cltftthaa5my7sxzlwiefbm@f2pqjvkffwqo>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <xp62aoh554ufuz64aizgozxxjc6cltftthaa5my7sxzlwiefbm@f2pqjvkffwqo>
User-Agent: Mutt/2.2.12 (2023-09-09)
Archived-At: 
 <https://www.postgresql.org/message-id/20250325224440.0f.nmisch%40google.com>
Precedence: bulk

On Tue, Mar 25, 2025 at 04:56:53PM -0400, Andres Freund wrote:
> The repeated-iteration approach taken in pgaio_closing_fd() isn't the
> prettiest, but it's hard to to imagine that ever being a noticeable.

Yep.  I've reviewed the fixup code, and it looks all good.

> This survives a testrun where I use your torture patch and where I force all
> IOs to use ASYNC. Previously that did not get very far.  I also did verify
> that, if I allow a small number of FDs, we do not wrongly wait for all IOs.

I, too, see the test diffs gone.