Feedback-ID: ia2694551:Fastmail
Date: Wed, 26 Mar 2025 07:59:31 +0100
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@alvh.no-ip.org>
To: Amul Sul <sulamul@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>,
	Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
 jian he <jian.universality@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>,
 Joel Jacobson <joel@compiler.org>,
	Alexandra Wang <alexandra.wang.oss@gmail.com>,
 Suraj Kharage <suraj.kharage@enterprisedb.com>
Subject: Re: NOT ENFORCED constraint feature
Message-ID: <202503260659.is27tpldi4zy@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAAJ_b95ANYeT9_TDTz5uhpHDGGRvhuyq7UB+ssK_i+DfK-fnPA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202503260659.is27tpldi4zy%40alvherre.pgsql>
Precedence: bulk

On 2025-Mar-26, Amul Sul wrote:

> The reason for the change is to revert to the behavior before commit
> #80d7f990496b1c, where recursion occurred regardless of the
> changed flags. This is also described in the header comment for
> ATExecAlterConstrDeferrability() (earlier it was for
> ATExecAlterConstraintInternal):
> 
>  * Note that we must recurse even when the values are correct, in case
>  * indirect descendants have had their constraints altered locally.
>  * (This could be avoided if we forbade altering constraints in partitions
>  * but existing releases don't do that.)

Umm, why?  Surely we should not allow a partition tree to become
inconsistent.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
#error "Operator lives in the wrong universe"
  ("Use of cookies in real-time system development", M. Gleixner, M. Mc Guire)