Date: Sat, 29 Mar 2025 20:18:09 +0900 (JST)
Message-Id: <20250329.201809.1463386697879435538.ishii@postgresql.org>
To: krasiyan@gmail.com
Cc: ojford@gmail.com, tgl@sss.pgh.pa.us, vik@postgresfriends.org,
 pgsql-hackers@postgresql.org, andrew@tao11.riddles.org.uk, david@fetter.org
Subject: Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options
From: Tatsuo Ishii <ishii@postgresql.org>
In-Reply-To: 
 <CAN1PwomkQhCb50oF8cUJUkjgdwCjPKXLW10_DdoPR_baPxLi=Q@mail.gmail.com>
References: 
 <CAGMVOdvAfKzfjDoA747fGNxYKdXG3rBiqRnwaz=FTcqW1TyOOA@mail.gmail.com>
	<CAGMVOduuhBa5b9ZzsJ2EwQZKFJhtjx3j4xwmbvfNo8Oks63mZw@mail.gmail.com>
	<CAN1PwomkQhCb50oF8cUJUkjgdwCjPKXLW10_DdoPR_baPxLi=Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/20250329.201809.1463386697879435538.ishii%40postgresql.org>
Precedence: bulk

> Hi,
> Patch applies and compiles, all included tests passed and after the latest
> fixes for non-nulls array, performance is near to lead/lag without support
> of "ignore nulls".
> I have been using the last version for more than one month in a production
> environment with real data and didn't find any bugs, so It is ready for
> committer status.

One thing I worry about the patch is, now the non-nulls array
optimization was removed.  Since then I have been thinking about if
there could be other way to optimize searching for non null rows.

Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp