Date: Sat, 26 Apr 2025 16:03:15 -0700
From: Noah Misch <noah@leadboat.com>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Nathan Bossart <nathandbossart@gmail.com>,
	Michael Paquier <michael@paquier.xyz>,
	Robert Pang <robertpang@google.com>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>, robertmhaas@gmail.com,
	pgsql-hackers@postgresql.org
Subject: Re: Back-patch of: avoid multiple hard links to same WAL file after
 a crash
Message-ID: <20250426230315.35.nmisch@google.com>
References: <Z_ECg-lN2xQbqkLc@paquier.xyz>
 <2461391.1743865633@sss.pgh.pa.us>
 <20250405191339.8d.nmisch@google.com>
 <Z_GxukueQn7lDs1u@paquier.xyz>
 <20250406020958.95.nmisch@google.com>
 <20250413153312.12.nmisch@google.com>
 <850092.1744559517@sss.pgh.pa.us>
 <Z_xUl6EyD3Txa9V3@paquier.xyz>
 <20250420215339.e8.nmisch@google.com>
 <f7ekxpwertlg2k4ux6dexi23k6n63fq5f7w5v3k5r556sw7dh7@ukyye6rmw6uv>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f7ekxpwertlg2k4ux6dexi23k6n63fq5f7w5v3k5r556sw7dh7@ukyye6rmw6uv>
User-Agent: Mutt/2.2.12 (2023-09-09)
Archived-At: <https://www.postgresql.org/message-id/20250426230315.35.nmisch%40google.com>
Precedence: bulk

On Fri, Apr 25, 2025 at 03:35:06PM -0400, Andres Freund wrote:
> On 2025-04-20 14:53:39 -0700, Noah Misch wrote:
> > The checkpoints and WAL creation took 30s, but archiving was only 20% done
> > (based on file name 00000001000000000000006D) at the 360s PGCTLTIMEOUT.
> 
> Huh.  That seems surprisingly slow, even for valgrind.  I guess it's one more
> example for why the single-threaded archiving approach sucks so badly :)

Yes!  I also didn't expect that v14/v13 would run much faster.

> I just changed the config to --trace-children=no. There already is a valgrind
> run in progress, so it won't be in effect for the next run.

Works for me.  I see that resolved things.