public inbox for [email protected]  
help / color / mirror / Atom feed
From: Álvaro Herrera <[email protected]>
To: Tom Lane <[email protected]>
Cc: [email protected]
Subject: Re: Accounting for metapages in genericcostestimate()
Date: Wed, 30 Apr 2025 12:47:51 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 2025-Apr-28, Tom Lane wrote:

> @@ -135,6 +141,7 @@ typedef struct
>  	double		numIndexTuples; /* number of leaf tuples visited */
>  	double		spc_random_page_cost;	/* relevant random_page_cost value */
>  	double		num_sa_scans;	/* # indexscans from ScalarArrayOpExprs */
> +	BlockNumber numNonLeafPages;	/* # of index pages that are not leafs */
>  } GenericCosts;

The idea you described seems quite reasonable, though I didn't review
the patch in detail.

I find the use of "leafs" as plural for "leaf" a bit strange ...
We already have uses of that word, but I wonder if they don't mostly
or exclusively come from non-native English speakers.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/






view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Accounting for metapages in genericcostestimate()
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox