Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uCgC6-000o2B-WB for pgsql-hackers@arkaria.postgresql.org; Wed, 07 May 2025 14:56:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uCgC5-00EgU8-U8 for pgsql-hackers@arkaria.postgresql.org; Wed, 07 May 2025 14:56:21 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uCgC5-00EgTz-6s for pgsql-hackers@lists.postgresql.org; Wed, 07 May 2025 14:56:21 +0000 Received: from fhigh-a4-smtp.messagingengine.com ([103.168.172.155]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uCgC0-000e8V-2J for pgsql-hackers@lists.postgresql.org; Wed, 07 May 2025 14:56:20 +0000 Received: from phl-compute-01.internal (phl-compute-01.phl.internal [10.202.2.41]) by mailfhigh.phl.internal (Postfix) with ESMTP id 1C581114018C; Wed, 7 May 2025 10:56:15 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-01.internal (MEProxy); Wed, 07 May 2025 10:56:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kurilemu.de; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to; s=fm1; t=1746629775; x= 1746716175; bh=VuMPHEZoafsWTspEj3BiHoM20vmSyJ3P1egcMB8p2CQ=; b=g rbPOfBafbFpTVnADGa3aTpcjemrOLrItVLa9UJv1G1WD9/lEkao1VZDzUaIF7yTq Odjzvv7+J53w5lVLULP8zyizCwD74Da8bjEx7l4TtmFnbVDe2Qdd33jTpwm67x2k po7rqfqaNgclTyRytKdiNrOE3UtKepbb3Eb1nIY/jJzTW90ysy7+3Ci5NV4XzTeu TqS4UPYh11RH0dnhXf4rAn6nO69G3aVEAxmCEQSFieZG4NW454DecNBCd0jZ+i3Z 673MqPkYSZdpVSPF5+Zbmjj4aNNtePhxbDByRH9C8rNjDGUOqKSHoCNx0PCdaGX3 ZZeDbHxtN7TFs/Z2J9leg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1746629775; x=1746716175; bh=V uMPHEZoafsWTspEj3BiHoM20vmSyJ3P1egcMB8p2CQ=; b=j1t2r5gAbJGGcOYD6 vWyYn44JuhCQxPgR/h4Z0GsOnCqbWA//2nfZXrnFtC3drEcYKNaqUglNdc/fzFZA JUzntv901Q19HVcmnhob4gSKzyZ6iUZ5qiCL3og44UUHo/kyvekGbef0VlO+QfJ+ O+BKiZ7yUZuPWFwLbFYpKlEf9ggc2LOw8yYDVcKan8pSA3j91aKkNrUNQueVo7re p2hrXcXqkMyQlS0F3B/377i/L4fFaPiMEFXyWXYBuiFPqDOOT9uc2/6N5OQg01nB X/rEWfyw5JnpXt6V4kIR0PQMkgh57SLuOKi2f8fekEHDHnJxWbOzagBqcL1um2r/ 8HPSQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvkeejudehucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhepfffhvfevuffkgggtugfgjgesthekredttddt jeenucfhrhhomheplmhlvhgrrhhoucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsehkuh hrihhlvghmuhdruggvqeenucggtffrrghtthgvrhhnpeetuedvheffkeevgfeuheevteev kefggedttdeufeeuheduuddthfeffffhjeefffenucffohhmrghinhepvghnthgvrhhprh hishgvuggsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomheprghlvhhhvghrrhgvsehkuhhrihhlvghmuhdruggvpdhnsggprhgtphhtth hopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehjihgrnhdruhhnihhvvghr shgrlhhithihsehgmhgrihhlrdgtohhmpdhrtghpthhtohepphhgshhqlhdqhhgrtghkvg hrsheslhhishhtshdrphhoshhtghhrvghsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: ie3de48e3:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 7 May 2025 10:56:14 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kurilemu.de; s=schmee; t=1746629761; bh=SAWStUwYBqKnTIhOUJ/1cqSAiyWvG/L1NrRQeJPIQ3U=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=gLC33wX6BPh+n3MnTAmMCKTbmjxWGR3vt1enT9zoPu8KFkq4oomC5iQqGYOuV37Ja s/ngvjEFK6CvfYaO/YcskXAdCnj5RpyYJ/6cyn/bYmQ5QAMHs3R7fWExaQ2tMdL6jk BLSFeB+S975MpuzAn9/Tf4rjeDo+uYZJFfTUaewRVefBOWZIDtjvVywZe4GpDQ/E5J Btk5fGtwNiQM4MlD3T6B/fkSapfgm+vnuRzR2oGcNzGL2W2mNY1NvTmqpBPYtAvwbr bcAfgfof6BfPO9XvvWmic1nywIgm83kZee8O/hANq/pjr5B20XlBKbLiGa99WrXCvi SDQk2Uy7aa5aQ== Received: by schmee.alvh.no-ip.org (Postfix, from userid 1000) id D36E890; Wed, 7 May 2025 16:56:01 +0200 (CEST) Date: Wed, 7 May 2025 16:56:01 +0200 From: =?utf-8?Q?=C3=81lvaro?= Herrera To: jian he Cc: PostgreSQL Hackers Subject: Re: pg_dump does not dump domain not-null constraint's comments Message-ID: <202505071456.elpjza2ky65d@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Ooh, you know what? I ran your the CREATE DOMAIN statement in your new test and pg_dump'ed that, and as far as I can tell the _name_ of the not-null constraint is not dumped either. So it's not just the comment that we're losing. That's a separate bug, and probably needs to be fixed first, although I'm not sure if that one is going to be back-patchable. Which means, I withdraw my earlier assessment that the comment fix is back-patchable as a whole. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/