Feedback-ID: ie3de48e3:Fastmail
Date: Fri, 23 May 2025 09:54:54 +0200
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: Bruce Momjian <bruce@momjian.us>
Cc: Nazir Bilal Yavuz <byavuz81@gmail.com>,
	PostgreSQL-development <pgsql-hackers@lists.postgresql.org>,
 Thomas Munro <thomas.munro@gmail.com>
Subject: Re: PG 18 release notes draft committed
Message-ID: <202505230754.fsspbpqhybqt@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <aCyUrG9vu1eDo26b@momjian.us>
Archived-At: 
 <https://www.postgresql.org/message-id/202505230754.fsspbpqhybqt%40alvherre.pgsql>
Precedence: bulk

On 2025-May-20, Bruce Momjian wrote:

> On Tue, May 20, 2025 at 05:15:54PM +0300, Nazir Bilal Yavuz wrote:
> > > As of the date of the commit, "Co-authored-by:" is listed as:
> > >
> > >         https://wiki.postgresql.org/wiki/Commit_Message_Guidance

> No problem.  The "Co-authored-by:" guidance was only written down in
> January of this year.  I assume Thomas Munro was following that guidance
> when he wrote the commit message.

FWIW I have not taken to following that page yet, particularly because
the chosen page title is pretty random, there are no links to it, and I
couldn't find it when I searched for it; I wouldn't assume anyone is
using it as if it were already gospel.

Anyway, in order to contribute I added a few links to it, and also fixed
the markup some.


TBH I don't agree with everything the page says.  For instance, I don't
think we should care about what gitweb does with the commit title.
gitweb is a dying interface and we'd do good to get rid of it, relying
instead on cgit only.  cgit shows more than 50 chars of the commit
title, so I don't think there's a reason to limit oneself to 50 chars
there.

I also think that showing an XML-ish format of a commit message is
unhelpful, not to mention hard to read.  Showing a few actual examples
would be better.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
¡Ay, ay, ay!  Con lo mucho que yo lo quería (bis)
se fue de mi vera ... se fue para siempre, pa toíta ... pa toíta la vida
¡Ay Camarón! ¡Ay Camarón!                                (Paco de Lucía)