Feedback-ID: ia2694551:Fastmail
Date: Thu, 5 Jun 2025 19:01:06 +0200
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: jian he <jian.universality@gmail.com>
Cc: Amul Sul <sulamul@gmail.com>, Tender Wang <tndrwang@gmail.com>,
	pgsql-hackers@lists.postgresql.org, Antonin Houska <ah@cybertec.at>
Subject: Re: Foreign key validation failure in 18beta1
Message-ID: <202506051701.wjgu2jhnksb5@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CACJufxE0KRLtrapdQOYw1TW+BbfcbLrng7S7fzDz+M_T1RDknw@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202506051701.wjgu2jhnksb5%40alvherre.pgsql>
Precedence: bulk

On 2025-Jun-04, jian he wrote:

> On Tue, Jun 3, 2025 at 12:14 PM Amul Sul <sulamul@gmail.com> wrote:
>
> > I found a third approach that requires only a few changes. The key
> > idea is to determine the root referenced table and pass it to
> > QueueFKConstraintValidation(). We would then enqueue phase 3
> > validation only if the constraint tuple’s confrelid matches that root
> > table -- similar to what is doing in ATExecAlterConstrEnforceability().
> >
> > This would also ensure that the logic for adding/skipping phase 3
> > validation is consistent in both places.
>
> indeed!
> 
> v7 is way more intuitive compared with v5, v6.

Agreed, this version is better than the previous ones.  I split it as
two commits, for NOT VALID and NOT ENFORCED separately, and modified some
comments a bit as well as the commit messages.

Thank you!

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"Cuando mañana llegue pelearemos segun lo que mañana exija" (Mowgli)