public inbox for [email protected]  

help / color / mirror / Atom feed

From: Yugo Nagata <[email protected]>
To: Yugo NAGATA <[email protected]>
Cc: Fujii Masao <[email protected]>
Cc: Laurenz Albe <[email protected]>
Cc: Nathan Bossart <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: [email protected]
Subject: Re: Extend ALTER DEFAULT PRIVILEGES for large objects
Date: Wed, 11 Jun 2025 11:49:37 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<20240424210839.GA863220@nathanxps13>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

On Tue, 8 Apr 2025 12:28:57 +0900
Yugo NAGATA <[email protected]> wrote:

> On Fri, 4 Apr 2025 19:18:11 +0900
> Fujii Masao <[email protected]> wrote:
> 
> > 
> > 
> > On 2025/04/04 0:21, Fujii Masao wrote:
> > > Thanks for updating the patch!
> > > 
> > > If there are no objections, I'll proceed with committing it using the following commit log.
> > 
> > I've pushed the patch. Thanks!
> 
> Thank you!
> 
>  
> > While testing the feature, I noticed that psql doesn't complete
> > "ALTER DEFAULT PRIVILEGES GRANT/REVOKE ... ON LARGE OBJECTS" or
> > "GRANT/REVOKE ... ON LARGE OBJECT ..." with TO/FROM. The attached
> > patch adds tab-completion support for both cases.
> 
> This patch looks good to me. This works as expected.
> 
> While looking into this patch, I found that the tab completion suggests
> TO/FROM even after "LARGE OBJECT", but it is not correct because
> there should be largeobject id at that place. This is same for the
> "FOREIGN SERVER", server names should be suggested ratar than TO/FROM
> in this case. 
> 
> The additional patch 0002 fixed to prevents to suggest TO or FROM right
> after LARGE OBJECT or FOREIGN SERVER. Also, it allows to suggest list of
> foreign server names after FOREIGN SERVER.
> 

While looking at the thread [1], I've remembered this thread.
The patches in this thread are partially v18-related, but include
enhancement or fixes for existing feature, so should they be postponed
to v19, or should be separated properly to v18 part and other?

[1] https://www.postgresql.org/message-id/70372bdd-4399-4d5b-ab4f-6d4487a4911a%40oss.nttdata.com

Best regards,
Yugo Nagata

-- 
Yugo Nagata <[email protected]>

view thread (33+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Extend ALTER DEFAULT PRIVILEGES for large objects
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox