Date: Wed, 11 Jun 2025 13:57:37 +0900
From: Yugo Nagata <nagata@sraoss.co.jp>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>, Nathan Bossart
 <nathandbossart@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
 <pgsql-hackers@postgresql.org>
Subject: Re: Extend ALTER DEFAULT PRIVILEGES for large objects
Message-Id: <20250611135737.bb7d3135141248819704ebca@sraoss.co.jp>
In-Reply-To: <b448cc01-ce8d-45f3-a922-c63490bbdec4@oss.nttdata.com>
References: <20240424115242.236b499b2bed5b7a27f7a418@sraoss.co.jp>
	<3602391.1713930458@sss.pgh.pa.us>
	<20240424210839.GA863220@nathanxps13>
	<20240426175406.13e47ea3904de814afbfe496@sraoss.co.jp>
	<20240913161801.b1e60534d77fa9df447b775f@sraoss.co.jp>
	<9c0c4d7881d2450baf70edb0ae95415a81ac8cb1.camel@cybertec.at>
	<20250123192220.9bad2b9aec110bf335521276@sraoss.co.jp>
	<fb552452-d61f-403b-85c1-187ea7f030af@oss.nttdata.com>
	<20250403230418.f41b23d155f6c6cb3cebcd92@sraoss.co.jp>
	<dfa9a1fc-1570-45a0-8735-57c414629cec@oss.nttdata.com>
	<ade0ab29-777f-47f6-9d0d-1af67728a86e@oss.nttdata.com>
	<20250408122857.b2b06dde4e6a08290af02336@sraoss.co.jp>
	<20250611114937.b067c542192f8e5e740a2a4a@sraoss.co.jp>
	<b448cc01-ce8d-45f3-a922-c63490bbdec4@oss.nttdata.com>
Content-Type: multipart/mixed;
 boundary="Multipart=_Wed__11_Jun_2025_13_57_37_+0900_QIhod5B/NnD=PcxW"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?Y99AxQTHDzH3KAGvTDKcEljBrnfPgcOSfhpe8fV9jgzwydL7e4RGdGYDQLFX?=
 =?us-ascii?Q?DKHG64pKKFj24Hm3N5vEM0FK+DoEmd5spRkZoa6F1OAD7bL2LI3dF3emrkBw?=
 =?us-ascii?Q?8zwrModCy40KszNUXoLN4YZru4gha7mR/E5XDm/ECOA/Qz/jNGVTzoy8aL1B?=
 =?us-ascii?Q?9F6mXATE4iA6B/ruwYFcquErb9S3GeWdbRkAjLN5iqNsOvyTiwCquumgzivV?=
 =?us-ascii?Q?5v8065DIpgWP0dR3O9aV+4qt0HMyph5a/RNhU8k5oF2yOYljtexzE8MVCZSR?=
 =?us-ascii?Q?obXiP2OoRMA8AqjQqtR1/07PjX8X0fGyAFB1B1VVtd4B8CW7VRzMd5ilhNKZ?=
 =?us-ascii?Q?pFoPBTCHw713VaFxiBiS2lSWvdfhBu0WVu05lhAcomM//8Rs5orbLZFcFfyH?=
 =?us-ascii?Q?GcgsvNZZ5zWs0Dv9cI8JADZgZW4+Oa5yl2lQjxhFRa5oUtEAScfRUtRCza3M?=
 =?us-ascii?Q?A6gLtH67GIwToGUldCBTD16dUosuotNoYwm1qHnuxVDs9K+NtboiMvbHJxwh?=
 =?us-ascii?Q?95bRgMpFCstxJsJWSu7G9yXEMkvP7ybfZmGknrYyNlbQ9uPh3zVtRgBrFClj?=
 =?us-ascii?Q?J6Czd6CrJy7UO6Nb+W6f1+R7hyjLnXWlIDORqknYjfkSgZbR9BZ+gqtxpFKr?=
 =?us-ascii?Q?KQSCTQeuxuNHtnvzYUnGxIZwxVLQvSKZ1zws1c2V6/9o0V3yC/M6ZKadbwMW?=
 =?us-ascii?Q?2LJ7aESEGF3/typmIJ6Zg/g23VdXd8DZnAbJO/AH2IUYH4ZaTzIfWl9Uv7LA?=
 =?us-ascii?Q?mcyED4sGZ5segYBuXjsxSsULp9iHCG8Hx253OYMisk6C083Hf9Ys/RYVHW/o?=
 =?us-ascii?Q?FmDKxwqBHUi8Q+FwzJQEsoWS+Jrvm5c5apzpXUSoOQEaPu8yC+RxnLzPMmH8?=
 =?us-ascii?Q?arSWMomzlv5YyMQzGVp2grJ0XyRFoyyJ5Ejvk5HduuiZx6OKh2n2vDiKvlNs?=
 =?us-ascii?Q?Uk4FaqLrSa6GKtGq3gLtph5JX2VCWK9SqyPn5PpZaAIYCw3zggBzsI+OA+Cp?=
 =?us-ascii?Q?N1PIWX7RLOK+jyuJrV0atElRCyDhRAOT/3y2POwnUCL1n+/IjTI1fmNnA3MM?=
 =?us-ascii?Q?qT7Ci0tRu+vvURTvDknnXwNGN8YADatSS7wNqJ++FH0FrS4ilbfL09V+75cL?=
 =?us-ascii?Q?c4egjcz9XnSOl36S0oBrz8mno3Iiu/bmZp2xPBrKNGkkSJZE6/lTBQOLhgpG?=
 =?us-ascii?Q?mF7TM32zM0dGeZIsklntlQbhv/GTacyjTIzH1/WvB2ezdvY/5Uk/V7ZUIRP9?=
 =?us-ascii?Q?4maTUlWTNVoyw6+Z5Vl09pt/yC3iuDgViivrg/lkMNRVFGKucCd/J3tGRik2?=
 =?us-ascii?Q?z1h5u9XYlTBmTQQV8bOF/vN+p2uhea1LYYUDjOejL2T2C4kO4JEfTNqsfCPG?=
 =?us-ascii?Q?4ZMV4w5ztdqQ4ngaKzJukJ2LcrY0qxdeclLecTh5omp7hMbkYMbOpta1SCjK?=
 =?us-ascii?Q?p2In6SHnfk9o1O/l0AtyOTHuyjFR37lpXP86xyrzHIu3PA0z0QUOjRrhM5Ng?=
 =?us-ascii?Q?kjSGtSXXCA5tdXEWrDA7p5hHFcG1pwIVmyy5GhihLtEhLYNI+buARkADS5he?=
 =?us-ascii?Q?K6JUksFy+WLyq1RtJDuhQU6QDW+HsvBYTmdrSSJi?=
X-OriginatorOrg: sraoss.co.jp
X-MS-Exchange-CrossTenant-Network-Message-Id: 
 4769975a-9082-4888-4856-08dda8a47cfd
X-MS-Exchange-CrossTenant-AuthSource: OSZP286MB2160.JPNP286.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2025 04:57:38.3303
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 75db6c32-352e-4063-ae79-cafb8623f6db
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 
 x9lO33uk8Oj3Nr3ZOa9q7D8uHO3EHDYx2FYVkMJIJSPlVAzpid2/kE76MqsQ3b0Et/zSduY45+BkQc0K1tRkoA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS9P286MB5079
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/20250611135737.bb7d3135141248819704ebca%40sraoss.co.jp>
Precedence: bulk

--Multipart=_Wed__11_Jun_2025_13_57_37_+0900_QIhod5B/NnD=PcxW
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 11 Jun 2025 13:33:07 +0900
Fujii Masao <masao.fujii@oss.nttdata.com> wrote:

> 
> 
> On 2025/06/11 11:49, Yugo Nagata wrote:
> > While looking at the thread [1], I've remembered this thread.
> > The patches in this thread are partially v18-related, but include
> > enhancement or fixes for existing feature, so should they be postponed
> > to v19, or should be separated properly to v18 part and other?
> > 
> > [1] https://www.postgresql.org/message-id/70372bdd-4399-4d5b-ab4f-6d4487a4911a%40oss.nttdata.com
> 
> I see these patches more as enhancements to psql tab-completion,
> rather than fixes for clear oversights in the original commit.
> 
> For example, if tab-completion for ALTER DEFAULT PRIVILEGES had
> completely missed LARGE OBJECTS, that would be an obvious oversight.
> But these patches go beyond that kind of issue.
> 
> That said, if others think it's appropriate to include them in v18
> for consistency or completeness, I'm fine with that.
> 
> Regarding the 0002 patch:
> 
> -	else if (Matches("GRANT", MatchAnyN, "ON", MatchAny, MatchAny))
> -		COMPLETE_WITH("TO");
> -	else if (Matches("REVOKE", MatchAnyN, "ON", MatchAny, MatchAny))
> -		COMPLETE_WITH("FROM");
> +	else if (Matches("GRANT/REVOKE", MatchAnyN, "ON", MatchAny, MatchAny))
> +	{
> +		if (TailMatches("FOREIGN", "SERVER"))
> +			COMPLETE_WITH_QUERY(Query_for_list_of_servers);
> +		else if (!TailMatches("LARGE", "OBJECT"))
> +		{
> +			if (Matches("GRANT", MatchAnyN, "ON", MatchAny, MatchAny))
> +				COMPLETE_WITH("TO");
> +			else
> +				COMPLETE_WITH("FROM");
> +		}
> +	}
> 
> Wouldn't this change break the case where "GRANT ... ON TABLE ... <TAB>"
> is supposed to complete with "TO"?

Sorry, I made a stupid mistake.

> +	else if (Matches("GRANT/REVOKE", MatchAnyN, "ON", MatchAny, MatchAny))

This should be "GRANT|REVOKE".

I've attached update patches. (There is no change on 0001.)

Best regards,
Yugo Nagata

-- 
Yugo Nagata <nagata@sraoss.co.jp>

--Multipart=_Wed__11_Jun_2025_13_57_37_+0900_QIhod5B/NnD=PcxW
Content-Type: text/x-diff;
 name="v2-0002-psql-Some-improvement-of-tab-completion-for-GRANT.patch"
Content-Disposition: attachment;
 filename="v2-0002-psql-Some-improvement-of-tab-completion-for-GRANT.patch"
Content-Transfer-Encoding: 7bit