Date: Tue, 01 Jul 2025 09:19:06 +0900 (JST)
Message-Id: <20250701.091906.2172190057744262508.ishii@postgresql.org>
To: krasiyan@gmail.com
Cc: ojford@gmail.com, tgl@sss.pgh.pa.us, vik@postgresfriends.org,
 andrew@tao11.riddles.org.uk, david@fetter.org, pgsql-hackers@postgresql.org
Subject: Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options
From: Tatsuo Ishii <ishii@postgresql.org>
In-Reply-To: 
 <CAN1PwokLY34h+=b6noW3UE=1=CZXYQg3_mKnTBzbuP0gmDT1-A@mail.gmail.com>
References: <20250625.161903.68476237519416014.ishii@postgresql.org>
	<20250630.142556.158881195489030489.ishii@postgresql.org>
	<CAN1PwokLY34h+=b6noW3UE=1=CZXYQg3_mKnTBzbuP0gmDT1-A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/20250701.091906.2172190057744262508.ishii%40postgresql.org>
Precedence: bulk

Krasiyan,

> Hi,
> Patch applies and compiles, all included tests passed and performance gain
> is really impressive. I have been using the latest versions for months with
> real data and didn't find any bugs, so It is definitely ready for committer
> status.

Thanks for testing the patch. The CF status has been already set to
"ready for committer". I just changed the target version from 18 to
19.

> I am not sure how the case where frame clause is "RANGE" or "GROUPS"
> and frame end is "CURRENT ROW" is majority of window function use
> cases. If it's majority, the optimization in v14 does not help much
> because v14 does not optimize the case.  However if it's not, the v14
> patch is close to commitable form, I think. Comments are welcome.

Have you tested cases where the frame option is "RANGE" or "GROUPS"
and the frame end is "CURRENT ROW"? I am asking because in these cases
the optimization in the v14 (and v15) patches do not apply and you may
not be satisfied by the performance.

Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp