Date: Sun, 6 Jul 2025 09:13:19 -0700
From: Noah Misch <noah@leadboat.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Michael Banck <mbanck@gmx.net>,
	Greg Sabino Mullane <htamfids@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] Add support for displaying database service in psql
 prompt
Message-ID: <20250706161319.c1.nmisch@google.com>
References: <6723c612.050a0220.1567f4.b94a@mx.google.com>
 <CAKAnmmKhnHGp4X3FvMAicRsbyiKTWwMJ6oWdkRw2oLVzdeL-0A@mail.gmail.com>
 <6748cfd4.050a0220.1537dc.43bb@mx.google.com>
 <Z1fv8D_t1ok8svgO@paquier.xyz>
 <6760a25e.a70a0220.2e9d8f.d542@mx.google.com>
 <Z2ErmZD1lImYt_as@paquier.xyz>
 <6761397c.df0a0220.68885.210d@mx.google.com>
 <Z2JpAD4395C-qALl@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Z2JpAD4395C-qALl@paquier.xyz>
User-Agent: Mutt/2.2.12 (2023-09-09)
Archived-At: 
 <https://www.postgresql.org/message-id/20250706161319.c1.nmisch%40google.com>
Precedence: bulk

On Wed, Dec 18, 2024 at 03:17:36PM +0900, Michael Paquier wrote:
> Done.

This new PQservice() function from commit 4b99fed75 came up in the annual
exports.txt diff.  The standard in libpq has been to not clutter the API with
new functions that simply retrieve one PQconninfoOption value.  PQconninfo()
provides access to all those values in a generic way.  What do you think of
making psql use PQconninfo() for this, then removing PQservice()?  The rest of
the commit (adding the struct field, necessary for PQconninfo() to include the
value) looks good.