Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uYkqW-00AiBa-6f for pgsql-hackers@arkaria.postgresql.org; Mon, 07 Jul 2025 12:21:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uYkqT-001k8j-Vh for pgsql-hackers@arkaria.postgresql.org; Mon, 07 Jul 2025 12:21:18 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uYkqT-001k8X-MX for pgsql-hackers@lists.postgresql.org; Mon, 07 Jul 2025 12:21:18 +0000 Received: from fhigh-a3-smtp.messagingengine.com ([103.168.172.154]) by makus.postgresql.org with smtp (Exim 4.96) (envelope-from ) id 1uYkqS-0062Fb-1u for pgsql-hackers@lists.postgresql.org; Mon, 07 Jul 2025 12:21:17 +0000 Received: from phl-compute-04.internal (phl-compute-04.phl.internal [10.202.2.44]) by mailfhigh.phl.internal (Postfix) with ESMTP id D8CDA14000F1; Mon, 7 Jul 2025 08:21:15 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Mon, 07 Jul 2025 08:21:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kurilemu.de; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to; s=fm3; t=1751890875; x= 1751977275; bh=TAgOrNp4dBABVUEqbLLFZClNikpY18MJpLQ1PG3S8B0=; b=L +7K+vYcubHSUbYyzq22bZN66ltJKv3KkYs/NuIl1A3NTdOUlWIa1SMfOgtieupk+ NSv0D6m/e7cJeFhIiOoxfuDF+D757zHtjima++NjAUQwPRCDnMx7oLcomv0wnOH/ uOkUEjGaqKl9bxYUtHxzzlWWbD8PMORW2dLwKZfVQ3crBUureEI/8mkG8Cr4Yn1m Ahxniw/1bFXHsI5PQf2UtptwG7Fa1UHMipXCVyRh/1LEJXO6UOviwsqrKDCD0d+A GpGmBHm4A+cuVpsoIlEsZSJInyCZgSSfl5La5XKpmydU+MRd9TFTxBeJ5+3Gb5SX kNi8f+2XKgEG6RsqyUT+g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1751890875; x=1751977275; bh=T AgOrNp4dBABVUEqbLLFZClNikpY18MJpLQ1PG3S8B0=; b=RSKVHGvCtVGVhXL2U 2McZ6IT2xuAsJsuOSrRP7KUrEbrv63qEYb+90Bj+WmWlykC2I+RJ6ccN0D16sg74 no19Jm6nVC7Qixhszbjd7Ex+bYhS6UN/H9fKG45RfuTKteLoACWfVLW1WXgysZnW 1RezTwvHnReSG2mNwwhjPIC9h9l9Nt1+4XRiXZ36Iy5KE6kgVvaVkXHGmJMTdWRP cFmfifRl+rT2Hu7SirUc389WyYGJPWAQKditjehe5s1w9R0R6F25kPHPFs1IoZy2 S1PXTRYN28vPR7jwUnj6PS9agGixp0nP9/eAcDL/JBvnJO3SDwiecwix3XLAzuuH Vac1w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdefudejkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpeffhffvvefukfggtggugfgjsehtkeertddttdejnecuhfhrohhmpemllhhvrghrohcu jfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgeskhhurhhilhgvmhhurdguvgeqnecuggftrf grthhtvghrnhepteeuvdehffekvefgueehveetveekgfegtddtueefueehuddutdfhfeff hfejfeffnecuffhomhgrihhnpegvnhhtvghrphhrihhsvggusgdrtghomhenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhvhhgvrhhrvges khhurhhilhgvmhhurdguvgdpnhgspghrtghpthhtohepfedpmhhouggvpehsmhhtphhouh htpdhrtghpthhtoheprghrshgvnhhihidrmhhukhhhihhnrdguvghvsehgmhgrihhlrdgt ohhmpdhrtghpthhtohepphhgshhqlhdqhhgrtghkvghrsheslhhishhtshdrphhoshhtgh hrvghsqhhlrdhorhhgpdhrtghpthhtohepthhomhgrshesvhhonhgurhgrrdhmvg X-ME-Proxy: Feedback-ID: ie3de48e3:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 7 Jul 2025 08:21:15 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kurilemu.de; s=schmee; t=1751890874; bh=uXS2K5D6/uDWU7xzeE9ZlyFjjVL7PD397qYF37/CdeQ=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=3XKpjL4qWOxwFyqjBP6ydp8clfLpNNKXViA2HU+4MFLbq2w4HtkC3Uf7etvHPUlp5 WTRX+x5DV4m8Ngh8vM4nDRG+u731qE2et7S5QSETBwm9oHTRXmlourhhuClrGAU9UH SxkTe530S1yIL6i8J7nILK4d2XMNYRJfP/o7YceoL7PdFFZT697lSDOJucGvaLLe56 teHQ9obyTNwfABdZHZd/mnTsS8PXeeCvLoBUvMOvSIQcQcQtaH0bjMWj4OAPSSBB2F taghaQsgyxakdvTqzWcoCTS1PqsjemGe8nKkKJ8vuVJ76FLg2qRj0vBY4JQX4JiYQN KJ0+mmddCLrdg== Received: by schmee.kurilemu.internal (Postfix, from userid 1000) id 61EC090; Mon, 7 Jul 2025 14:21:14 +0200 (CEST) Date: Mon, 7 Jul 2025 14:21:14 +0200 From: =?utf-8?Q?=C3=81lvaro?= Herrera To: Tomas Vondra Cc: Arseniy Mukhin , PostgreSQL Hackers Subject: Re: amcheck support for BRIN indexes Message-ID: <202507071221.am6rbd6n4dct@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2025-Jul-07, Tomas Vondra wrote: > Alvaro, what's your opinion on the introduction of the new WITHIN_RANGE? > I'd probably try to do this using the regular consistent function: > > (a) we don't need to add stuff to all BRIN opclasses to support this > > (b) it gives us additional testing of the consistent function > > (c) building a scan key for equality seems pretty trivial > > What do you think? Oh yeah, if we can build this on top of the existing primitives, then I'm all for that. -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/