Date: Thu, 10 Jul 2025 10:30:41 +0900
From: Yugo Nagata <nagata@sraoss.co.jp>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>, Nathan Bossart
 <nathandbossart@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
 <pgsql-hackers@postgresql.org>
Subject: Re: Extend ALTER DEFAULT PRIVILEGES for large objects
Message-Id: <20250710103041.f93be994017e4ab61b9b9c35@sraoss.co.jp>
In-Reply-To: <a09986e3-958c-4151-8244-f43c28701ddf@oss.nttdata.com>
References: <20240424115242.236b499b2bed5b7a27f7a418@sraoss.co.jp>
	<3602391.1713930458@sss.pgh.pa.us>
	<20240424210839.GA863220@nathanxps13>
	<20240426175406.13e47ea3904de814afbfe496@sraoss.co.jp>
	<20240913161801.b1e60534d77fa9df447b775f@sraoss.co.jp>
	<9c0c4d7881d2450baf70edb0ae95415a81ac8cb1.camel@cybertec.at>
	<20250123192220.9bad2b9aec110bf335521276@sraoss.co.jp>
	<fb552452-d61f-403b-85c1-187ea7f030af@oss.nttdata.com>
	<20250403230418.f41b23d155f6c6cb3cebcd92@sraoss.co.jp>
	<dfa9a1fc-1570-45a0-8735-57c414629cec@oss.nttdata.com>
	<ade0ab29-777f-47f6-9d0d-1af67728a86e@oss.nttdata.com>
	<20250408122857.b2b06dde4e6a08290af02336@sraoss.co.jp>
	<20250611114937.b067c542192f8e5e740a2a4a@sraoss.co.jp>
	<b448cc01-ce8d-45f3-a922-c63490bbdec4@oss.nttdata.com>
	<20250611135737.bb7d3135141248819704ebca@sraoss.co.jp>
	<a09986e3-958c-4151-8244-f43c28701ddf@oss.nttdata.com>
Content-Type: multipart/mixed;
 boundary="Multipart=_Thu__10_Jul_2025_10_30_41_+0900_+vbMe+39TnIY2O7J"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?fsoXn0ojTe3zzpvvf5gAP2pULAQa2QimL5NtSmVdb4eqwsI0JW2nuZwS8/vc?=
 =?us-ascii?Q?EtYKfWXYz05fhh11WNYcZ7g2mRW8KKH10jd5xQ/A2t72iDOiwp4cWmz7Zgwg?=
 =?us-ascii?Q?BKWdI/CrSjCQdX/o0snIrz7Ztr7WHJvJJ+wpWALqwR/5TdH8ih2mc/2BM773?=
 =?us-ascii?Q?pUDtpJf+CQwKC76fSUc/mlwdcj3yjK5UN/X9XWrlww1jK/RzPXYM5ei3dOaa?=
 =?us-ascii?Q?pEKCwZHVjrX6Dp/IaKIXmxGNP8Js9ze2bauHVmvP0WGaxEKG3LdF+HUMLgo/?=
 =?us-ascii?Q?/8Zpfvy5mBZsfflPibSBr/+q9Jo07Y4WG6wmeGn6Ia5N4eT6f4wtafhox1GV?=
 =?us-ascii?Q?jbWSDF6bYyHC/O4EdYphIPV7LVdkeZKejRBQG6gHTXRf/7y7yvJ+X/ZFjZdr?=
 =?us-ascii?Q?hg1xwj/SxfoMMRVQCoh48FDySh9PQAt5OS513/n/+dpzWS+8ej5xlZRnPxky?=
 =?us-ascii?Q?A6qBGS7oTXGWDhlMnK5okpKdPvyR+UqmNPqfL/cAyRBGgEnC3y/ir1m5M5ln?=
 =?us-ascii?Q?q2UzXsvNbD6+5gySUw3/zJBX4owZtfOZfmBX2ITQoBn/1EcB5nARUreO8AS4?=
 =?us-ascii?Q?KYaD7WtPaMU4DOHC6vjF64XFj2yljLdwmbS+dkNE8K5W/W/0Oeo/71faxhFr?=
 =?us-ascii?Q?MhYrA/VKePRuFjCKlTjLsU+DBC9VZhr5Zf2HwFKd8OgpzJcv0JNFdUcUz78b?=
 =?us-ascii?Q?aXpsN2zPFK7DiY47wPmniUv5XprvNJOb0CBgFJ0zqVRll/k6gTErXEyG3UO6?=
 =?us-ascii?Q?NbBb5BI100Zp9GoUo5SbTzm8BG04wAwHCaVTG1lYkIm5sLVCMo8B8Uu0c31u?=
 =?us-ascii?Q?46vJdKidbZrkHims54PHNwV8jONTQZ7PGkt2fJPkg5CicQlHqAUrFSAH2Ubt?=
 =?us-ascii?Q?ZTx0ZSshvr3/KLUpbx3lF+uxPKm5/Emf56SEyRwb1tJfg5ODrVWBecatoCrR?=
 =?us-ascii?Q?W/yH4OcDrN7hkJTBy5UuyVYHyM+YkqRCPhjY7mKBm+CGzaalZKgQsNiC4btn?=
 =?us-ascii?Q?fdKL77WKqYZ6AZLiRKeTp1EGHyl128yo+4JJzj7DXVPukSJy7ih84yVQ00u8?=
 =?us-ascii?Q?7dlHtHHGzSDQatOXrPRaMTCJPA8Nv2sgMe+7GPlgR30JMymRd7g4lm+wOsfv?=
 =?us-ascii?Q?PzPNggMdTZ0dEXFsYNsZq3Kb7zh7MGe6xM3mZzGgM2DLUewvnWdsGYWq9226?=
 =?us-ascii?Q?hSu1WNwa55u9bgVQnBQ/XQowafSQXRBnaxTJmFYKbHTEpHlmE1geLSYaORPd?=
 =?us-ascii?Q?uNFR22ycIaePZqg+1cpYLaa+Q0NRQd3GTPTD3NguFlkVcGKJ5PXNfwCNspJL?=
 =?us-ascii?Q?9cfmPANxOojP5g8RTYEaAnKTxBRcSSyhxgydBhHRtLtr9jmFhIkXo1SOidCR?=
 =?us-ascii?Q?jHSqAxRNcHcXabO0dBb7DLiMlWEWWnaD4/4Ih9w2cvERCqx7xtjmIAfNwjXg?=
 =?us-ascii?Q?SgLEEdfK51qU6m9NzfIYngr73UyhqVGEFNxQfzfH3XaDI70UPjlqzamVd2K1?=
 =?us-ascii?Q?X6KN7np45udoaE7aw8F4Ww/hwrXmXBepoFIN8fPvsMhiA+R5sHBuL9p5qLRs?=
 =?us-ascii?Q?KVOfVqreXGAw+OGGtcQ5JXRnyFW8uC74ii489mPo?=
X-OriginatorOrg: sraoss.co.jp
X-MS-Exchange-CrossTenant-Network-Message-Id: 
 9a4884b7-04f3-4e42-1582-08ddbf516258
X-MS-Exchange-CrossTenant-AuthSource: OSZP286MB2160.JPNP286.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2025 01:30:42.2252
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 75db6c32-352e-4063-ae79-cafb8623f6db
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 
 3mOPRB1s7eWjeLM8sh85wW0TlRDp638mJvRYTyggQyPs9s/u3ioeHw/zosNMj3F6CcHB/eBBbPURSaKw2BRX9Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY4P286MB6294
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/20250710103041.f93be994017e4ab61b9b9c35%40sraoss.co.jp>
Precedence: bulk

--Multipart=_Thu__10_Jul_2025_10_30_41_+0900_+vbMe+39TnIY2O7J
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 9 Jul 2025 20:42:42 +0900
Fujii Masao <masao.fujii@oss.nttdata.com> wrote:

> 
> 
> On 2025/06/11 13:57, Yugo Nagata wrote:
> > On Wed, 11 Jun 2025 13:33:07 +0900
> > Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
> > 
> >>
> >>
> >> On 2025/06/11 11:49, Yugo Nagata wrote:
> >>> While looking at the thread [1], I've remembered this thread.
> >>> The patches in this thread are partially v18-related, but include
> >>> enhancement or fixes for existing feature, so should they be postponed
> >>> to v19, or should be separated properly to v18 part and other?
> >>>
> >>> [1] https://www.postgresql.org/message-id/70372bdd-4399-4d5b-ab4f-6d4487a4911a%40oss.nttdata.com
> >>
> >> I see these patches more as enhancements to psql tab-completion,
> >> rather than fixes for clear oversights in the original commit.
> >>
> >> For example, if tab-completion for ALTER DEFAULT PRIVILEGES had
> >> completely missed LARGE OBJECTS, that would be an obvious oversight.
> >> But these patches go beyond that kind of issue.
> >>
> >> That said, if others think it's appropriate to include them in v18
> >> for consistency or completeness, I'm fine with that.
> >>
> >> Regarding the 0002 patch:
> >>
> >> -	else if (Matches("GRANT", MatchAnyN, "ON", MatchAny, MatchAny))
> >> -		COMPLETE_WITH("TO");
> >> -	else if (Matches("REVOKE", MatchAnyN, "ON", MatchAny, MatchAny))
> >> -		COMPLETE_WITH("FROM");
> >> +	else if (Matches("GRANT/REVOKE", MatchAnyN, "ON", MatchAny, MatchAny))
> >> +	{
> >> +		if (TailMatches("FOREIGN", "SERVER"))
> >> +			COMPLETE_WITH_QUERY(Query_for_list_of_servers);
> >> +		else if (!TailMatches("LARGE", "OBJECT"))
> >> +		{
> >> +			if (Matches("GRANT", MatchAnyN, "ON", MatchAny, MatchAny))
> >> +				COMPLETE_WITH("TO");
> >> +			else
> >> +				COMPLETE_WITH("FROM");
> >> +		}
> >> +	}
> >>
> >> Wouldn't this change break the case where "GRANT ... ON TABLE ... <TAB>"
> >> is supposed to complete with "TO"?
> > 
> > Sorry, I made a stupid mistake.
> > 
> >> +	else if (Matches("GRANT/REVOKE", MatchAnyN, "ON", MatchAny, MatchAny))
> > 
> > This should be "GRANT|REVOKE".
> > 
> > I've attached update patches. (There is no change on 0001.)
> 
> Thanks for updating the patch! At first I've pushed the 0001 patch.
> 
> As for the 0002 patch:
> 
> +		if (TailMatches("FOREIGN", "SERVER"))
> +			COMPLETE_WITH_QUERY(Query_for_list_of_servers);
> 
> This part seems not needed, since we already have the following tab-completion code:
> 
> /* FOREIGN SERVER */
> 	else if (TailMatches("FOREIGN", "SERVER"))
> 		COMPLETE_WITH_QUERY(Query_for_list_of_servers);
> 
> Thought?

You're right. I must have overlooked something. I think I saw "TO" being
suggested after "FOREIGN SERVER" when no foreign servers were defined.

The attached patch still prevents "TO/FROM" from being suggested after
"FOREIGN SERVER" in such cases. But perhaps this corner case doesn't really
need to be handled?


Regards,
Yugo Nagata

-- 
Yugo Nagata <nagata@sraoss.co.jp>

--Multipart=_Thu__10_Jul_2025_10_30_41_+0900_+vbMe+39TnIY2O7J
Content-Type: text/x-diff;
 name="v3-0001-psql-Some-improvement-of-tab-completion-for-GRANT.patch"
Content-Disposition: attachment;
 filename="v3-0001-psql-Some-improvement-of-tab-completion-for-GRANT.patch"
Content-Transfer-Encoding: 7bit