Date: Thu, 10 Jul 2025 14:11:29 +0900
From: Yugo Nagata <nagata@sraoss.co.jp>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>, Nathan Bossart
 <nathandbossart@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
 <pgsql-hackers@postgresql.org>
Subject: Re: Extend ALTER DEFAULT PRIVILEGES for large objects
Message-Id: <20250710141129.94cb58f465e706fa37c1b9d2@sraoss.co.jp>
In-Reply-To: <610c7506-3cd2-41c6-8346-581d120cf841@oss.nttdata.com>
References: <20240424115242.236b499b2bed5b7a27f7a418@sraoss.co.jp>
	<3602391.1713930458@sss.pgh.pa.us>
	<20240424210839.GA863220@nathanxps13>
	<20240426175406.13e47ea3904de814afbfe496@sraoss.co.jp>
	<20240913161801.b1e60534d77fa9df447b775f@sraoss.co.jp>
	<9c0c4d7881d2450baf70edb0ae95415a81ac8cb1.camel@cybertec.at>
	<20250123192220.9bad2b9aec110bf335521276@sraoss.co.jp>
	<fb552452-d61f-403b-85c1-187ea7f030af@oss.nttdata.com>
	<20250403230418.f41b23d155f6c6cb3cebcd92@sraoss.co.jp>
	<dfa9a1fc-1570-45a0-8735-57c414629cec@oss.nttdata.com>
	<ade0ab29-777f-47f6-9d0d-1af67728a86e@oss.nttdata.com>
	<20250408122857.b2b06dde4e6a08290af02336@sraoss.co.jp>
	<20250611114937.b067c542192f8e5e740a2a4a@sraoss.co.jp>
	<b448cc01-ce8d-45f3-a922-c63490bbdec4@oss.nttdata.com>
	<20250611135737.bb7d3135141248819704ebca@sraoss.co.jp>
	<a09986e3-958c-4151-8244-f43c28701ddf@oss.nttdata.com>
	<20250710103041.f93be994017e4ab61b9b9c35@sraoss.co.jp>
	<610c7506-3cd2-41c6-8346-581d120cf841@oss.nttdata.com>
Content-Type: multipart/mixed;
 boundary="Multipart=_Thu__10_Jul_2025_14_11_29_+0900_WtsizlP9soM8NNZ1"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?/VWi9qw3yd86A1MxHf4jPeeFd0rby5pkvtiRmHB9G6IUW7GhIO8+dJxB6T2q?=
 =?us-ascii?Q?g01+FKMjYubet4QCtOVyIkwD/9ohGrXlQmkXLKlD9s8fvbyDsJiiA0nauOB/?=
 =?us-ascii?Q?3RfqgXFE834A6fhDVrJwRjTT/c3CS8NNf3tmKtl4jC5W9mQgMQoGdLDoLm22?=
 =?us-ascii?Q?epodcFO0/iXLu3krPn6/2/o43uJqUDDyP2QRXsAFFsHEbbTWi3twNTmZjYfp?=
 =?us-ascii?Q?jxFClRVHfOgxTSuNRJpntFlKXCweZBaoo1Yz9oz15uoxJMWymFvEVFaOwfSl?=
 =?us-ascii?Q?n3oaEsOULoDC8FzPVDmYiHY1G+TDQh9yD6LWTcdsTfcMBNXwOmH/IJS6tiqW?=
 =?us-ascii?Q?mf6+PUbDCvpcsFp6R9ErbN4CmdbMwNc0QV3JiHbgRLgoTTunwioDlF9nVu00?=
 =?us-ascii?Q?iPO6tomr2UDZwfQ4o+Mkabw0JWsVr1NiV7vQFO3el0R+98RR1BTrwFK05qVc?=
 =?us-ascii?Q?YKa8pFXWeT0uWWoX2drytxcR5PZHxI2NMCWJTEpTasEvp1zIZh8P8TTpStv0?=
 =?us-ascii?Q?cWfKYsqOCNBjaJzBlfK9VrMmOi/BF+XK68tLGQ8+ZR2+pEOuJbmAi2Iss7cy?=
 =?us-ascii?Q?+8quMRnZlgF9uUmurgJrOMFlH5weWJWmS+quobiqU+2JDg7ejGhG1rN9C79T?=
 =?us-ascii?Q?pFuSbez1fxjGIYK4u8CwmT6H4+Q5q5+4iAFpcKX99JHrNcd5SDgXA/PIw+8T?=
 =?us-ascii?Q?okMV9GwgjzzXR/OmUbNzIbaw+ofuHykiop8ZZnY1IzbbqfU2d1Pvj3oLa2ZW?=
 =?us-ascii?Q?zlBJi02KE2I/w60WVabISnXu4Wcy52JHilcbI6D1T8Q1VI2RaiisLQpV0Eon?=
 =?us-ascii?Q?2aFU67UFnCC9sSGSwnJyR5+CD9kHYV7H98nxTfOF66Ai7BnthpOT8Coq/5U3?=
 =?us-ascii?Q?SyXXAB9HbOGo7TucnnD1eNBHYog4yo2ZeypxfYvpIEM5B3q0b/eSVnR7vyL4?=
 =?us-ascii?Q?T+oeszMtZuJLffLQkemrHkaDmiPTAShvuSxiSTjOGBA0vVZ2vFrVbpMY+F3c?=
 =?us-ascii?Q?B5CWmw+EviVmWeBkl0eD+/Qih9wzzvMsini709Vy2FmUR/kAUwAFr7LAZSwr?=
 =?us-ascii?Q?GfzDQYFVwZlAdqXkHnGmWUJ+sP2KCjnh/9igh++gvdywBSR/48ABo63t4k0I?=
 =?us-ascii?Q?Mj2FtBpeWvkEyu/+ruiLkx2AvnzKAmAhdPURnygclkr+Le2tYMjWoPknHyAA?=
 =?us-ascii?Q?0L3afbmGRDIA0+BmtUTiUusZaKzWMhT3MkbSaiHXl2P/QW3SeAYNk3169rsd?=
 =?us-ascii?Q?HF2UhhCfxvzHJYIp7MKGT82jPpQv4AfgQDWK7NmfM58foUgRFaFa9U5zLsqT?=
 =?us-ascii?Q?ak9vJjhcP4ksz82YVOps8zXWDzzDfchEOgTs3gu5N+xNobJ/U6dxBShayc6b?=
 =?us-ascii?Q?iJqrW2rafy80u6ftAtmEco0/JQW19Aoj805ODmBQFUkAUTF4iFmR/fKFYqh9?=
 =?us-ascii?Q?v2DucbTYkYDRf0VwHHmlVvJMyw8zLuyqlEIneE295v83aE7Mp7Y0O/QvTL2J?=
 =?us-ascii?Q?ObphkI1b9i/ehe2q2poIOSxnvYlg4a0n2DIim6cVEr7vDHF3uoJo5Xs5/L7P?=
 =?us-ascii?Q?/pnM/lor15kA0+8E6hJQTpNWLFGrCkO9SpE4y6kX?=
X-OriginatorOrg: sraoss.co.jp
X-MS-Exchange-CrossTenant-Network-Message-Id: 
 b234ac86-73b1-4e05-84e4-08ddbf703b25
X-MS-Exchange-CrossTenant-AuthSource: OSZP286MB2160.JPNP286.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2025 05:11:30.8614
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 75db6c32-352e-4063-ae79-cafb8623f6db
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 
 G2rYq6Ezz95XO0Q7HSHTMfwTy+1Lpt42ZyLmdQqsUg1H4jzT/T1WL6TfDit/M/GG0Mvj5KgYvukU3YhK2kp7Vw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCP286MB3820
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/20250710141129.94cb58f465e706fa37c1b9d2%40sraoss.co.jp>
Precedence: bulk

--Multipart=_Thu__10_Jul_2025_14_11_29_+0900_WtsizlP9soM8NNZ1
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 10 Jul 2025 13:23:47 +0900
Fujii Masao <masao.fujii@oss.nttdata.com> wrote:

> 
> 
> On 2025/07/10 10:30, Yugo Nagata wrote:
> > You're right. I must have overlooked something. I think I saw "TO" being
> > suggested after "FOREIGN SERVER" when no foreign servers were defined.
> > 
> > The attached patch still prevents "TO/FROM" from being suggested after
> > "FOREIGN SERVER" in such cases.

> 
> Based on your patch, I'm thinking of simplifying the code like this:
> 
> -       else if (Matches("GRANT", MatchAnyN, "ON", MatchAny, MatchAny))
> -               COMPLETE_WITH("TO");
> -       else if (Matches("REVOKE", MatchAnyN, "ON", MatchAny, MatchAny))
> -               COMPLETE_WITH("FROM");
> +       else if (Matches("GRANT|REVOKE", MatchAnyN, "ON", MatchAny, MatchAny) &&
> +                        !TailMatches("FOREIGN", "SERVER") && !TailMatches("LARGE", "OBJECT"))
> +       {
> +               if (Matches("GRANT", MatchAnyN, "ON", MatchAny, MatchAny))
> +                       COMPLETE_WITH("TO");
> +               else
> +                       COMPLETE_WITH("FROM");
> +       }

Thank you for your review!
 I agree with your suggestion and have updated the patch accordingly.

> 
> > But perhaps this corner case doesn't really
> > need to be handled?
> 
> Probably I failed to get your point here. Could you clarify what you meant?

I'm sorry for not explaining it clearly.

Currently, TO or FROM could be suggested immediately after FOREIGN SERVER, but
only when no foreign servers are defined. When foreign servers do exist,
their names are correctly suggested instead, as expected.

The patch fixed the behavior so that TO or FROM are not suggested after FOREIGN SERVER,
even when no foreign servers are defined. However, I've started to wonder if it's worth
fixing such a corner case. What do you think?

Regards,
Yugo Nagata

-- 
Yugo Nagata <nagata@sraoss.co.jp>

--Multipart=_Thu__10_Jul_2025_14_11_29_+0900_WtsizlP9soM8NNZ1
Content-Type: text/x-diff;
 name="v4-0001-psql-Some-improvement-of-tab-completion-for-GRANT.patch"
Content-Disposition: attachment;
 filename="v4-0001-psql-Some-improvement-of-tab-completion-for-GRANT.patch"
Content-Transfer-Encoding: 7bit