Feedback-ID: ie3de48e3:Fastmail
Date: Tue, 29 Jul 2025 20:22:24 +0200
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: Jeff Davis <pgsql@j-davis.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>,
	Robert Haas <robertmhaas@gmail.com>, Peter Eisentraut <peter@eisentraut.org>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pg_dump --with-* options
Message-ID: <202507291822.z4sc4ddvg2kx@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <13a2cd63ec37d42b65bde5dadc39b61861e97cbc.camel@j-davis.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202507291822.z4sc4ddvg2kx%40alvherre.pgsql>
Precedence: bulk

On 2025-Jul-29, Jeff Davis wrote:

> +	/* reject conflicting "only-" and "with-" options */
> +	if (data_only && with_schema)
> +		pg_fatal("options -a/--data-only and --with-schema cannot be used together");
> +	if (data_only && with_statistics)
> +		pg_fatal("options -a/--data-only and --with-statistics cannot be used together");
> +	if (schema_only && with_data)
> +		pg_fatal("options -s/--schema-only and --with-data cannot be used together");
> +	if (schema_only && with_statistics)
> +		pg_fatal("options -s/--schema-only and --with-statistics cannot be used together");
> +	if (statistics_only && with_data)
> +		pg_fatal("options --statistics-only and --with-data cannot be used together");
> +	if (statistics_only && with_schema)
> +		pg_fatal("options --statistics-only and --with-schema cannot be used together");

Please move the switches themselves out of the translatable message,
otherwise there are too many of them.  For instance,

	pg_fatal("options %s and %s cannot be used together",
	         "-s/--schema-only", "--with-statistics");

Thanks

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/