Date: Tue, 29 Jul 2025 13:34:25 -0700
From: Noah Misch <noah@leadboat.com>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	Mahendra Singh Thalor <mahi6run@gmail.com>,
	=?iso-8859-1?Q?=C1lvaro?= Herrera <alvherre@alvh.no-ip.org>,
	jian he <jian.universality@gmail.com>,
	Srinath Reddy <srinath2133@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Non-text mode for pg_dumpall
Message-ID: <20250729203425.32.nmisch@google.com>
References: 
 <CAKYtNAppY=vVtTMdkxRPV48cHKyzLeYF6mrPk15Wczme7e9=ww@mail.gmail.com>
 <3f22a8bb-29e8-40cc-97a1-309181da2c13@dunslane.net>
 <20250722005339.ca.nmisch@google.com>
 <a5359ad4-4e2b-432d-92c0-188f9d558f06@dunslane.net>
 <20250725162141.6f.nmisch@google.com>
 <d1bfd0e7-f70c-48ef-ad5c-ac9d251e4b4c@dunslane.net>
 <2225040.1753477169@sss.pgh.pa.us>
 <20250727235628.e2.nmisch@google.com>
 <8f2ad50b-ebb7-4adc-997e-25e0ad96ff34@dunslane.net>
 <2bed001a-462c-42da-9a6b-3c7884502932@dunslane.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2bed001a-462c-42da-9a6b-3c7884502932@dunslane.net>
User-Agent: Mutt/2.2.12 (2023-09-09)
Archived-At: 
 <https://www.postgresql.org/message-id/20250729203425.32.nmisch%40google.com>
Precedence: bulk

On Tue, Jul 29, 2025 at 04:09:13PM -0400, Andrew Dunstan wrote:
> here's a reversion patch for master.

>     This reverts parts or all of the following commits:

I briefly looked through this.  The biggest non-reverted part is, I think,
c1da728 "Move common pg_dump code related to connections to a new file".
Refraining from a revert of that one is defensible.

>     dec6643487b Improve pg_dump/pg_dumpall help synopses and terminology

> @@ -1276,7 +1276,7 @@ main(int argc, char **argv)
>  static void
>  help(const char *progname)
>  {
> -	printf(_("%s exports a PostgreSQL database as an SQL script or to other formats.\n\n"), progname);
> +	printf(_("%s dumps a database as a text file or to other formats.\n\n"), progname);
>  	printf(_("Usage:\n"));
>  	printf(_("  %s [OPTION]... [DBNAME]\n"), progname);

I think commit dec6643487b, which e.g. decided to standardize on the term
"export" for these programs, was independent of $SUBJECT.