Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ujPVI-007Heq-Jp for pgsql-hackers@arkaria.postgresql.org; Tue, 05 Aug 2025 21:47:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1ujPVH-00CL2i-5u for pgsql-hackers@arkaria.postgresql.org; Tue, 05 Aug 2025 21:47:27 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ujPVG-00CL2W-QG for pgsql-hackers@lists.postgresql.org; Tue, 05 Aug 2025 21:47:26 +0000 Received: from fhigh-a8-smtp.messagingengine.com ([103.168.172.159]) by makus.postgresql.org with smtp (Exim 4.96) (envelope-from ) id 1ujPVE-000vV8-0F for pgsql-hackers@lists.postgresql.org; Tue, 05 Aug 2025 21:47:25 +0000 Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfhigh.phl.internal (Postfix) with ESMTP id EEBCF1400153; Tue, 5 Aug 2025 17:47:23 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Tue, 05 Aug 2025 17:47:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kurilemu.de; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to; s=fm1; t=1754430443; x= 1754516843; bh=1ujvX/8ZYiz08S602TwPejh3nYcd8iIW8k+qUPQ1s7c=; b=E SApbtSUTwU5XeiTW21AkoxPeT6ByDpEBM97l7KVaEsS9QKY83Q5DY/py8nVW+3nr Jstz/28hvyTgTnQ/99KnXu+m+3sm9mJMntqQvTVjSv5/0nLy0FZpjaynFqfcKQ2v w5idRnAZQUeTWHAEmuvHkan+Z4fCq0t6v093502wsB2e7fjnaTmXZ5yYl3QhKrBU 78asBzh7wY+t0QizwOYxbkmb5LxwG4JskITBZt5q4wKN3wWLpmK4F9nFH2/yHgWe +eZ8R/dSu6W7zYKw/3EMrXttdEhDhUZpRJA23ra6qiUo7XaHS9xDFtUmS+Z0cJFJ aPgqNApxZryShf4T5tIQQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1754430443; x=1754516843; bh=1 ujvX/8ZYiz08S602TwPejh3nYcd8iIW8k+qUPQ1s7c=; b=TCdiNuimS13WOlMAf 6cuT7OCRDrxHMpQ3Syt0ZNBYfNJwTxLBc60AESEl7lEXFVDSc5kxk59RuyTrpskZ kdnNFFm4fVbbDOUpkxcn3Znaik8sDEBZJHaKO4dbqwNoOgdKEJm7bJRf4A0L0lR8 Bn7U7WK1spxRjD37NvKEn+Xju1Qmp+46d8NSCMT8oHVdncDvzZWrbzd3czKZ01JA PLLlphFKaGp5QRKtWsSWee/VcWcv/PN+BuuWi/+d6VWuGLv0tAD22ssOPxwTv9bh bfz0NEG1M+oiviv7E6vxfCNkju67+CVw8Oq6aN8yyPS8OfYaNmWvNw64S3DPun95 MFp3w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdduudeivdelucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkgggtugfgjgesthekredttddtjeenucfhrhhomheplmhlvhgrrhho ucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsehkuhhrihhlvghmuhdruggvqeenucggtf frrghtthgvrhhnpeetuedvheffkeevgfeuheevteevkefggedttdeufeeuheduuddthfef fffhjeefffenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtohhmnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlvhhhvghrrhgv sehkuhhrihhlvghmuhdruggvpdhnsggprhgtphhtthhopeegpdhmohguvgepshhmthhpoh huthdprhgtphhtthhopehjrggtohgsrdgthhgrmhhpihhonhesvghnthgvrhhprhhishgv uggsrdgtohhmpdhrtghpthhtohepuggrvhgvtghrrghmvghrsehgmhgrihhlrdgtohhmpd hrtghpthhtohepnhgrthhhrghnuggsohhsshgrrhhtsehgmhgrihhlrdgtohhmpdhrtghp thhtohepphhgshhqlhdqhhgrtghkvghrsheslhhishhtshdrphhoshhtghhrvghsqhhlrd horhhg X-ME-Proxy: Feedback-ID: ie3de48e3:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 5 Aug 2025 17:47:23 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kurilemu.de; s=schmee; t=1754430441; bh=vK1rNFAcgLAasK6/n/42FROCyiCroJKRgD2KrjVIUkU=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=dhrjT4/uAt44mp/vp5ln0FfPhWKCXP0s0ddyvIIjQ+PB2vKwgH77lmqZzfoHjNYJE 0r2CW5vzyQ+zVq/3f87mVjowoFGeokjvLOWZwk3E/37ItvsBtbXg4yGCcONalbqbdJ evdsq66nc0Z+NhI86IzdbU+EwXZA8t8c2umS9qxRygf5I6hdZJ8QZjeAVwh1Iqo1/L 8XYCdvwChHGnc1ZM4B1CNk4CNS8SdYwYb8wuQ5jLlIugjctb3DYoQhpNKdnWOP6tmQ 8UpGf2jrKtG7lTXZtTH6VflmQZWQ89zE6NFYeJyvCGIhqjWKuyqqIsJqFVL8w2zdP9 w9+z+l4ULlbZA== Received: by schmee.kurilemu.internal (Postfix, from userid 1000) id BB03290; Tue, 5 Aug 2025 23:47:21 +0200 (CEST) Date: Tue, 5 Aug 2025 23:47:21 +0200 From: =?utf-8?Q?=C3=81lvaro?= Herrera To: Nathan Bossart Cc: Jacob Champion , Dave Cramer , PostgreSQL Hackers Subject: Re: More protocol.h replacements this time into walsender.c Message-ID: <202508052147.62zb6taiva5d@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2025-Aug-05, Nathan Bossart wrote: > Here is an updated patch that includes 1) added uses of PqMsg_* macros, 2) > new PqReplMsg_* macros, and 3) new PqBackupMsg_* macros. Thoughts? Hmm, I think if you're going to add the backup ones, then it'd be good to update ReceiveArchiveStreamChunk() to use these macros and this header file. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/