Feedback-ID: ie3de48e3:Fastmail
Date: Wed, 6 Aug 2025 00:14:44 +0200
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Nathan Bossart <nathandbossart@gmail.com>,
	pgsql-hackers@postgresql.org
Subject: Re: fix ancient typo in transformRelOptions()
Message-ID: <202508052214.sjldy4pl2uvk@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1290107.1754431854@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/202508052214.sjldy4pl2uvk%40alvherre.pgsql>
Precedence: bulk

On 2025-Aug-05, Tom Lane wrote:

> =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de> writes:
> > On 2025-Aug-05, Nathan Bossart wrote:
> >> I noticed that this function has a "namspace" parameter.  The attached
> >> patch adds the missing 'e'.
> 
> > I have vague recollections of it being this way because of "namespace"
> > being a C++ keyword.  (commit is 3a5b77371522, but I don't have energy
> > to look for the discussion right now.)
> 
> Oh, duh -- if you try cpluspluscheck you'll find it's unhappy.
> I didn't locate the discussion of "namspace" either, but I did
> notice that de160e2c0 used "nameSpace" for the same purpose.
> Maybe we should standardize on that?  It looks less like a typo
> than "namspace", for sure.

WFM.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"No deja de ser humillante para una persona de ingenio saber
que no hay tonto que no le pueda enseñar algo." (Jean B. Say)