Date: Fri, 8 Aug 2025 11:51:42 +0900
From: Yugo Nagata <nagata@sraoss.co.jp>
To: Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: Align tests for stored and virtual generated columns
Message-Id: <20250808115142.e9ccb81f35466a9a131a4c55@sraoss.co.jp>
Content-Type: multipart/mixed;
 boundary="Multipart=_Fri__8_Aug_2025_11_51_42_+0900_CP97CmrUzTBhq9M8"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?zFFuObMKSd3sPagOsJQckQ+6CElswNobCHcrdGo4qUURyHfWWf9WDMB3fwGK?=
 =?us-ascii?Q?7enjzjBFIzyi5lDs2qNseRANqV4q5BLbrruPYG97ScgeiIUCLVhGD5Fv+RDK?=
 =?us-ascii?Q?TcFMtJb8k3FpUwTXXEOnCEdqocBEm9AuyFODLs/fEMkVjzZ/S9wDCsNeKoLz?=
 =?us-ascii?Q?SkV2dMfCAlFhKZ6p3SN7Se7Se0DovY9DZK8i6XVP0hEfsgUCPCOaAxkZIra6?=
 =?us-ascii?Q?wwM8Zswz7j/pN/KmWlZIr5/9+QN0PnIreWi3RoNUJ7QncFvUuJ5qjBTFlwvT?=
 =?us-ascii?Q?1b/f4Jd5fcSH8vJMh4Oa9zyOi2OWZ8eNHFPihvXJVZc5+plG22D6GKWdxxD1?=
 =?us-ascii?Q?wNyatiGzyMoJpCpwVnesliANiWd5RBVXXyZL3XvQRJgg5A66657e7Tc48vWo?=
 =?us-ascii?Q?2WtnAzt1xOlYGLK586n8Dr8pQ+Jx4HXzk2jdPjnz0Rdg29wGYhaA9/IcNOK3?=
 =?us-ascii?Q?USEUtNrI6JTOjTLKG4mlfY9gxJMrwbwzFbWQrAp8ZOx6vHDIxQK+A9UQWp9f?=
 =?us-ascii?Q?YQKLN0MBvUdrPvkkKbpO4azczpFMQjWGZAN0vggsXW7mpjIvwtUFbzwvyBZ0?=
 =?us-ascii?Q?8iAeaCcYxFJQswkTd6xfJMi3FhdBQslZmv8xO0HWRkN5qTcYO8qI8BKxb/XL?=
 =?us-ascii?Q?aKV+uaFmhcGbWuiZ4k2K7s61aQ18HwVBxLqn2LGjTSnRQJMyuSlE/3wB38jo?=
 =?us-ascii?Q?EZj43ocFCQduYVlwV6rpmaO6lj7rJOl0qj8d/MjQlNVn69EacU8qztVWBHFe?=
 =?us-ascii?Q?8SnpOTd4r9gkBhyNgmyubdCWs8AQe+VyTQE5lzeMO61gGuo8WD1tzlirYT9k?=
 =?us-ascii?Q?UgB04QI1Xu5XwHAJzKl7Vd4MnO74JkPgnsntqxGBA+3JH5Doy2jsKHzpLuL+?=
 =?us-ascii?Q?9y0mKA5dqjQ52GZLhJT6bLhzEl0L5LqskplQSRg65Pq8GosAs9Wgt23F+D/h?=
 =?us-ascii?Q?01YsR44OckJaw7etrPOub00NM+/YEK65/Ac167M2ysbov5FGnuWVyiF3viSA?=
 =?us-ascii?Q?uSMO4Lvb3Kk6B5VyQ9OQ9fLjb9Nab/QVmx1ewWsbEbd9OP66rR8kpezDoKbb?=
 =?us-ascii?Q?q/FT/FseOzdLDKPcfoicZ9zK35hTi3syKzKpvr5u/fzM58BGXs9bcldmmDRZ?=
 =?us-ascii?Q?y4/TU9yOifZsDE5KbqZsyAJIaUQck+QKGYS20k6HlUI70GVoqTSskM7OeqID?=
 =?us-ascii?Q?4G7Dk7IE1KoJX5frouCTCECaQNH3gHioOMeYDPQofK7yJH1YVwBbcQkfCxhQ?=
 =?us-ascii?Q?Mf1jJTdyeEAmiCHjV/uQPsIzsC2z0jZx6Pv182H3EB6vh1H68OvdooYGFLCL?=
 =?us-ascii?Q?UOdz+RBGDoEbVrqhbJuN8wqLEg/PZvdoC+LMDhas83frDOmP96jSDU3MZw5c?=
 =?us-ascii?Q?WlMwGJhed2tUbVljmvwouTwK7wdwRNtzS93JLYILX+geJwkwCuTSY2jk2Wks?=
 =?us-ascii?Q?tGguEr5ORnk1TGPblyKElzeo/XMuFEY/oN3YN+mTKFKnmtF8XtMow0mG43lD?=
 =?us-ascii?Q?LhL0jh+JdDiZrcccbZSAxlT2eOavY1mWLjDzDypFVuTVRE0rJ43ECMIkg/jD?=
 =?us-ascii?Q?3WpU309MOBZYYkXAIxwbW9CMbdbNDzURVAz6Q4xHpF67vJBXZyzhEDHgesrE?=
 =?us-ascii?Q?RPd3wVzS5Nrb7+KnYg38XjbZ7yo/tZ8arULFxdgePmhB?=
X-OriginatorOrg: sraoss.co.jp
X-MS-Exchange-CrossTenant-Network-Message-Id: 
 5dcc57b6-750c-42c5-1b16-08ddd6268197
X-MS-Exchange-CrossTenant-AuthSource: OSZP286MB2160.JPNP286.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2025 02:51:42.8660
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 75db6c32-352e-4063-ae79-cafb8623f6db
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 
 t1YnAr5IPAWUq4+TmUPR7nmrVH/ExD1ISP7cc/GicHgJowTPFep2F8X4a6RbkCA7ZhKkKb7m9q1QdQtJSUUCzQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYTP286MB4150
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/20250808115142.e9ccb81f35466a9a131a4c55%40sraoss.co.jp>
Precedence: bulk

--Multipart=_Fri__8_Aug_2025_11_51_42_+0900_CP97CmrUzTBhq9M8
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Hi,

I noticed that the tests for virtual and stored generated columns
contain the following comment;

 -- keep these tests aligned with generated_stored.sql (or generated_virtual.sql)

However, it seems that some additional tests for virtual generated columns
disrupted that alignment, as they were not added to generated_stored.sql.

I've attached a patch to restore the alignment.

In addition, I moved the test confirming that user-defined types are not allowed
in virtual generated columns to the generated_virtual.sql-specific section,
since this test is not necessary for stored generated columns.

Regards,
Yugo Nagata

-- 
Yugo Nagata <nagata@sraoss.co.jp>

--Multipart=_Fri__8_Aug_2025_11_51_42_+0900_CP97CmrUzTBhq9M8
Content-Type: text/x-diff;
 name="0001-Align-tests-for-stored-and-virtual-generated-columns.patch"
Content-Disposition: attachment;
 filename="0001-Align-tests-for-stored-and-virtual-generated-columns.patch"
Content-Transfer-Encoding: 7bit