Date: Sun, 24 Aug 2025 09:08:16 -0700
From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>,
	Kirill Reshke <reshkekirill@gmail.com>,
	Alexander Lakhin <exclusion@gmail.com>,
	pgsql-hackers@postgresql.org, Robert Haas <robertmhaas@gmail.com>
Subject: Re: Test instability when pg_dump orders by OID
Message-ID: <20250824160816.06.nmisch@google.com>
References: 
 <CA+TgmoZXmAZmB9OZaXTiy-HG2_1d7UiYrFKXf17C_yLfPa5pQg@mail.gmail.com>
 <20250804000321.8b.nmisch@google.com>
 <d32aaa8d-df7c-4f94-bcb3-4c85f02bea21@gmail.com>
 <CALdSSPhZyLua3Vz2Ug8VOASbhP41h-7784MT8s9_+90eE06Aaw@mail.gmail.com>
 <20250810163659.71.nmisch@google.com>
 <CALdSSPjDpzTAJsOwyuBy9Hxz7dmZyNTamQWBjEsKJD0KFcbphg@mail.gmail.com>
 <20250823052019.43.nmisch@google.com>
 <20250823144505.88.nmisch@google.com>
 <3th37rt7erqwk3rj63kozbbt2p2rxfg4inz54p77jvq7usojqu@vo2w2gdugz5w>
 <163245.1756050601@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <163245.1756050601@sss.pgh.pa.us>
User-Agent: Mutt/2.2.12 (2023-09-09)
Archived-At: 
 <https://www.postgresql.org/message-id/20250824160816.06.nmisch%40google.com>
Precedence: bulk

On Sun, Aug 24, 2025 at 11:50:01AM -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > I wonder if it's worth adding support to CI to perform the cross-version
> > upgrade test. It'd be pretty easy to install all pgdg apt postgres packages to
> > the debian image, which then could be used as the source version...

I think catching this particular case would take more than that.  It entails
running the latest v16 src/test/regress suite, capturing the dump of that into
$animal_root/upgrade.$animal/REL_16_STABLE/*.sql, and seeing the upgrade
failure of that dump having the latest v16 regression objects.  I don't know
how to get there without a v16 source tree.

> I feel that that's the wrong tradeoff.  CI should be expected to be
> fairly cheap, not to catch everything the buildfarm could catch.

It can always be non-default, like the mingw test.